schrotty / punkirc-test Goto Github PK

In the README.md on line 88:
Should be -t="<test_1> <test_2>" instead of --t="<test_1> <test_2>".

A change in the authLines value in the config.properties does not change anything on how the testclient react for authorisation replys. The client still expects all "LUSER" messages.

Seit version 1.2.1, egal welches Format die RPL_WELCOME, RPL_YOURHOST, RPL_CREATED, RPL_MYINFO Strings haben, die Tests schlagen fehl mit:
[completeAuthAtOnce()@08:36:30]: Tried to parse an empty string!
Desweiteren scheint der Test-Client alter Strings im Puffer zu behalten, so behauptet er zum Beispiel bei PONG, dass er eine Antwort erhalten hat obwohl diese im Log nie steht und auch manuell getestet nie kommt. Ich denke hier bleiben die Strings von Registration im Puffer welcher als Antwort auf interpretiert. Außerdem fehlt hier ein Leerzeichen zwischen server_response und 'Closing Link' https://github.com/punkIRC/punkIRC-test/blob/master/src/main/antlr/de.rubenmaurer.punk/IRC.g4#L141
Des Weiteren wäre eine Beispiel Liste von Formaten, die der Test Client akzeptiert, schön. Am besten für mögliches alle RPLs und ERRs. Ich konnte in der neusten Version fast gar keinen Test passen und die alte Version war da auch nicht sehr aufschlussreich.

The version check is now, there the option for disabling it is gone, disabled by default.

Add unit tests

When I run the Pricefield Test client with the -t="All" Parameter it won't run at least the Ping/Pong Tests. Probably even more test are been skipped.

It stops after the NOTICEPRIVMSG Tests with an unexpected EOF while looking for matching `"'

See title

Missing 'parameter_*''s in config.properties cause program crash.

Test 'list1()' in class 'ListChannel' is failing without any kind of message.

Ich bin mir nicht zu 100% sicher, aber eigentlich müsste im Fall von topic4() doch 403 "No such channel" als Reply erwartet werden und kein 442 "You're not on that channel".
Da ein Client erzeugt wird, er sich autorisiert und dann versucht ein Topic zu bekommen obwohl kein Channel vorhanden ist.

https://github.com/punkIRC/punkIRC-test/blob/8fc3c519509b6352ea2493cd2699b6a42fab5653/src/main/java/de/rubenmaurer/punk/test/channel/TopicChannel.java#L61-L72

pricefield.log:

[2019-12-17 08:23:31]  DEBUG  SEND: USER schrottler * * :Rodolf Schrottler
[2019-12-17 08:23:36]  DEBUG  SEND: NICK schrotty
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 001 schrotty :Welcome to the Internet Relay Network [email protected]
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 002 schrotty :Your host is 0.0.0.0, running version 1.0
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 003 schrotty This server was created 17.12.2019 20:23
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 004 schrotty 0.0.0.0 1.0 ao mtov
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 251 schrotty :There are 1 users and 0 services on 1 servers
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 252 schrotty 0 :operator(s) online
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 253 schrotty 0 :unknown connection(s)
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 254 schrotty 0 :channels formed
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 255 schrotty :I have 1 clients and 1 servers
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 375 schrotty :- 0.0.0.0 Message of the day -
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 372 schrotty :- General Kenobi!
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 376 schrotty :End of MOTD command.
[2019-12-17 08:23:36]  DEBUG  SEND: TOPIC #Blackwell-Dorms
[2019-12-17 08:23:36]  DEBUG  RECV: :0.0.0.0 403 schrotty #Blackwell-Dorms :No such channel
[topic4()@08:23:36]: No message with response code 442 found!

Ggf. in der Readme ändern

"The number of clients in the RPL_LUSERME reply is the total number of connections, including unknown connections."

[2019-11-25 08:01:31] DEBUG SEND: LUSERS
[2019-11-25 08:01:31] DEBUG RECV: :irc.vsys.com 251 max :There are 1 users and 0 services on 1 servers
[2019-11-25 08:01:31] DEBUG RECV: :irc.vsys.com 252 max 0 :operator(s) online
[2019-11-25 08:01:31] DEBUG RECV: :irc.vsys.com 253 max 0 :unknown connection(s)
[2019-11-25 08:01:31] DEBUG RECV: :irc.vsys.com 254 max 0 :channels formed
[2019-11-25 08:01:31] DEBUG RECV: :irc.vsys.com 255 max :I have 1 clients and 0 servers
[lusers1()@08:01:31]: Expected: '1', but got '0'.

[2019-11-25 08:04:42] DEBUG SEND: LUSERS
[2019-11-25 08:04:42] DEBUG RECV: :irc.vsys.com 251 max :There are 4 users and 0 services on 1 servers
[2019-11-25 08:04:42] DEBUG RECV: :irc.vsys.com 252 max 0 :operator(s) online
[2019-11-25 08:04:42] DEBUG RECV: :irc.vsys.com 253 max 0 :unknown connection(s)
[2019-11-25 08:04:42] DEBUG RECV: :irc.vsys.com 254 max 0 :channels formed
[2019-11-25 08:04:42] DEBUG RECV: :irc.vsys.com 255 max :I have 4 clients and 0 servers
[lusers2()@08:04:42]: Expected: '1', but got '0'.

See title

See title

In Channel test client sends a 'Topic' command instead of 'TOPIC'.

The following tests are failing:

• list2/ 3/ 4
• partNoChannel1/ 2
• topic1/ 2
• whoisNoNick
• privmsgNoNick
• testJoin4/ 5

• Fix some issues which are blocking the testing using IntelliJ
• Improve code in general and remove unnecessary code

Code recognition fails to when hostname includes digits.

See title

See title

In the reply message "my_info" is probably a delimiter missing after the whitespace behind "server_responce".

See title

In evaluation the 'expected' varaible is switched with the 'real' one.

Example:
"Expected Elisabeth but got Chloe" should be "Expected Chloe but got Elisabeth "

Method to search for a new release.