Giter Club home page Giter Club logo

Comments (9)

G-dH avatar G-dH commented on May 23, 2024 1

@hyproman You can try V-Shell from the GitHub repository, the freezing should be fixed. V-Shell now restores the WindowPreview functions only if _init is still injected, this should be fine i most common situations and I'll improve it later.

from burn-my-windows.

hyproman avatar hyproman commented on May 23, 2024 1

Confirmed that your latest changes to V-Shell fixed this issue. Thanks!

from burn-my-windows.

Schneegans avatar Schneegans commented on May 23, 2024

Hi there! Thanks for the report. However, I cannot reproduce this on my end. Did you disable all other extensions? This could be caused by some interference with another extension...

from burn-my-windows.

hyproman avatar hyproman commented on May 23, 2024

Thanks for responding! Initially I (thought I) disabled all my extensions before reproducing, but...I just did a bit more testing and it seems I didn't do my due diligence after all.

The issue only occurs when I also have V-Shell enabled. I'm running v29 (2023-04-11).

So now I guess it's hard to say on which side the bug exists 😭

from burn-my-windows.

Schneegans avatar Schneegans commented on May 23, 2024

Maybe @G-dH has an idea what could be the reason? BMW overrides WindowPreview._init() here. I do not really have a clue how this could cause a recursion...

from burn-my-windows.

G-dH avatar G-dH commented on May 23, 2024

@hyproman Open the issue on V-Shell's GitHub, I'll look into it.

from burn-my-windows.

G-dH avatar G-dH commented on May 23, 2024

@Schneegans BMW injects WindowPreview._init and stores the original, then V-Shell does the same, but the original is now injected by the BMW. When the screen is locked, both restore their "original", BMW first - the real original, V-Shell later - including the BMW injection. Then, when the screen is unlocked, BMW stores its own injected _init as the original. This causes the recursion. The simplest solution would be for BMW to save the original only once per session.

from burn-my-windows.

hyproman avatar hyproman commented on May 23, 2024

@G-dH Thank you for debugging this, and my apologies for not moving the issue over to your side. I literally just sat down to do so 5 minutes ago and saw your reply 🤦

from burn-my-windows.

Schneegans avatar Schneegans commented on May 23, 2024

@G-dH thank you for looking into this! I assume that I can close this issue now?

from burn-my-windows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.