schneegans / burn-my-windows Goto Github PK

Please close after reading, so I just wanted to thank you very much to bring this to gnome after the cube. I have missed compiz/beryl for long sad years and I personally lack the shader foo or also have never ventured into such corners of a system.

Now as a feature request, if I may ask, is is possible to change the fire colors? Already now it is magnificent :)

I'm sure it hasn't escaped your attention that dialog windows don't get the same burn animation treatment.

There appears to be a separate destroy time for dialogs, but I'd be ok if they used the same time duration as NORMAL windows.
But if you did have one timer, to still change the DIALOG_DESTROY_WINDOW_ANIMATION_TIME variable regardless.

Pick a random effect for each closed window..

I'm curious if this would be fun!

Describe the Bug

I only get random animations now, and can't seem to choose a specific one from the configuration window.

Steps to reproduce the behavior:

1. Open the configuration window
2. Click on the drop down for 'Choose Effects'
3. Click on any of the options
4. See the field still just say 'Choose Effects'
5. Close multiple windows to see that it's just using one at random instead of the one chosen above.

Expected Behavior

The 'Choose Effects' should change to whatever was chosen (and ideally it should show show that when the configuration window is first opened unless it's set to random) and the windows should then just be closed with the chosen animation.

System

Please complete the following information:

• Pop!_OS 21.10 x86_64
• Burn-My-Windows version 8
• GNOME Shell version: 40.4.0 on x11

Here's an example: https://youtu.be/zWhEgdh0X9c?t=170

If anybody wants to work on this, there is a guide for creating new effects available! Just drop a note here if you start working on it so that it's not been implemented twice 😉

The Motivation

Add animation selection for "minimize window" besides "open window" and "close window".

The Solution

Add another entry in the general options part of the settings dialog to choose which animation is to be used, should you minimize a window.

It would be ridiculous if the window would break into pieces. Ideally, as if hit by a stone at the current pointer location...

Small issue, when close Firefox 95.0.2 (64 bity) on Fedora 35 - animation use transparent background instead on window as background for animation.

I have an extension called 'Show Application View When Workspace Empty'.
If I closed a window, the animation showed, unless it was the only window on that workspace. Then my extension prevented the animation from showing.
So I added a timer to my extension to allow for the animation time (imports.ui.windowManager.DESTROY_WINDOW_ANIMATION_TIME) before showing the Apps view when closing the last window on a workspace.
It works well, but your animation seems to finish early.
For example:
If I set the animation time to 10 seconds, my extension will show the Apps view after 10 seconds, but your animation seems to finish several seconds earlier.

Describe the Bug

After enabling "open window animation" (with a fire effect), windows opening as fullscreen are invisible. Window stays invisible even after exiting fullscreen. Closing with Alt+F4 makes the window visible while playing the "close window animation".

Steps to reproduce the behavior:

1. Enable "open window animation".
2. Launch something in fullscreen, ie. firefox --kiosk or subl --command toggle_full_screen

Expected Behavior

Expected the animation to play and window to show. Or at the very least, the window to show.

System

Please complete the following information:

• Ubuntu 20.04.
• Burn-My-Windows version 10.
• GNOME Shell version: 3.36.8

It would be cool, if we could use the animation also for opening windows...

There should be a detailed guide on how-to create new effects.

Describe the Bug

I noticed that apps built with libadwaita have an issue with this extension, the effect is expanding outside of the window itself. Most likely the shadow box? Not sure as i am no expert in this.

I have attached two screenshots.

Nautilus, GTK3 Version:

Junction, using libadwaita:

Probably should have chosen a more visible effect but i think its clear what im talking about :D
This happens with all apps using libadwaita that i have tried, all other apps work fine.

System

• Linux distribution: Manjaro Gnome
• Xorg, NVIDIA (latest drivers)
• Burn-My-Windows 9
• GNOME Shell version: 41.2

Got the update notice, went to the gnome page and did the update, then immediately the "Error" error message appeared. Then uninstalled and tried to install again. No chance! Error again. Error message, why this could not be installed, came none.

Fedora 35, Gnome 41.1
Burn My Windows version, I can not see. It is the very latest version, updated a few days ago.

Terminal output:

$ journalctl -f -o cat | grep -E 'burn-my-windows|'
Supervising 10 threads of 8 processes of 1 users.
Supervising 10 threads of 8 processes of 1 users.
Supervising 10 threads of 8 processes of 1 users.
Supervising 10 threads of 8 processes of 1 users.
Started Application launched by gnome-shell.
Started Application launched by gnome-shell.
Created slice Slice /app/org.gnome.Terminal.
Starting GNOME Terminal Server...
Started GNOME Terminal Server.
Started VTE child process 560629 launched by gnome-terminal-server process 560606.

Supervising 10 threads of 8 processes of 1 users.
Supervising 10 threads of 8 processes of 1 users.
Ignoring excess values in shadow definition
Ignoring excess values in shadow definition
Ignoring excess values in shadow definition
Ignoring excess values in shadow definition
Ignoring excess values in shadow definition
Ignoring excess values in shadow definition
Started dbus-:[email protected].
meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Started Application launched by gnome-shell.
Started Application launched by gnome-shell.
Failed to load module "pk-gtk-module"
syntax error: line 1 of stdin
Errors encountered in stdin; not compiled.
Started Application launched by gio open.
Started [email protected].
Stopping [email protected]...
Stopped [email protected].
Supervising 10 threads of 8 processes of 1 users.
Supervising 10 threads of 8 processes of 1 users.
Window manager warning: last_user_time (316379277) is greater than comparison timestamp (316379274).  This most likely represents a buggy client sending inaccurate timestamps in messages such as _NET_ACTIVE_WINDOW.  Trying to work around...
Window manager warning: W3 appears to be one of the offending windows with a timestamp of 316379277.  Working around...
Started dbus-:[email protected].
###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost

Translated with www.DeepL.com/Translator (free version)

The settings of extension [email protected] had an error:

Gtk.BuilderError: .:12:43 Invalid property: GtkViewport.scroll-to-focus

Stack trace:

PreferencesDialog@/home/darrin/.local/share/gnome-shell/extensions/[email protected]/prefs.js:37:19
buildPrefsWidget@/home/darrin/.local/share/gnome-shell/extensions/[email protected]/prefs.js:226:16
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

First off - great job! This extension is super cool, thanks for making it!

This is a very small "bug" report, since it took me a little while to figure it out, it might help someone else with the same problem.
I had my "Animations" switch turned off in gnome-tweaks and even though the "Burn my windows" extension was installed and enabled, I didn't see any animations:

Hope this is helpful to someone else with the same problem and feel free to close this whenever.

The Motivation

This pretty much sums it up: https://devrant.com/rants/2098889/wtf-is-up-with-open-source-projects-using-emojis-in-their-commit-messages-fuckin

The Solution

Use a rational, text base solution that doesn't require special keyboard use, like conventional commit.

The Alternatives

Burn the repo.

This is most noticeable on Energize B.

I couldn't see how to apply my equation I gave you for the Fire effect:
sqrt(1-progress*progress)

If you set the duration to the max 10 seconds, Energize B is worst followed by Wisps and TV effect (which aren't too far out).
Energize A looks about right.

I'm only noticing this due to my extension that causes the app view to appear when the last window closes.

The settings of extension [email protected] had an error:

Gtk.BuilderError: .:12:43 Invalid property: GtkViewport.scroll-to-focus

Stack trace:

PreferencesDialog@/home/user/.local/share/gnome-shell/extensions/[email protected]/prefs.js:37:19
buildPrefsWidget@/home/user/.local/share/gnome-shell/extensions/[email protected]/prefs.js:99:16
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

running on Debian stable.

The Motivation

It would be nice to be able to preview an effect, or the changes the parameters of an effect have, from within the settings window.

Currently to preview an effect one must:

1. Select the effect to preview in the General Options ▸ Close Window Animation list.
2. (Optional) De-select all other effects in Close Window Animation list. Otherwise multiple open/closes of a dummy window need to be performed, as a random effect will be selected on each close.
3. Open and then close a dummy window, like a Terminal.

The Solution

Add a Preview button on each effects settings page. When clicked, an example window should open, then after a small delay, closes automatically. The window should close with the effect and its parameters applied.

The Alternatives

• (Optionally open then) close any other window. A Terminal or Files window is a good choice.

Working version on Fedora 35 + Gnome Shell 41.3 is 7 - on upgrade to 8 - instead off - switch button, display - error badget.

Pop os on version 21.10 with version 40 gnome.
I do it according to the instructions but it doesn’t work.

Thanks for an amazing extension! Inspired by your recent feature to use random effects from a list I have this idea for a new feature:

The Motivation

Fire is awesome! But the same fire every time does not give the full potential

The Solution

It would be fantastic if you could select to close with fire each time, but have the color of the fire randomized from a list of selected color presets.

The Alternatives

If the option to select the presets to choose from is too much, it could just select randomly from all installed color presets.

Just an idea I thought would be nice. Do with it what you will. Thanks again! :)

I like using the QTile tiling window manager with compton for transparency. Has anyone gotten this extension to work without Gnome or know of a similar extension that would work?

Hi buddy,
Your Progress Is Rock Man
I have an additional effect 💡
could you add claw scratch
====================here is examples & free materials =================

1. https://www.vecteezy.com/vector-art/144607-knives-and-scratch-marks-vectors
2. https://www.vecteezy.com/search?qterm=claw-scratch-free&content_type=vector

===================================================
Cheers 😊

My extension "Show Application View When Workspace Empty" was tapping into DESTROY_WINDOW_ANIMATION_TIME to allow for animations to finish. But you're not using that method any more.
Than means my extension cuts the animation short. I could tap into your dconf settings I suppose but I would prefer to use something already in Gnome.

OS: Ubuntu 21.10 x86_64
DE: GNOME 40.5

Wont work at debian stable after last update.

Describe the Bug

The extension works fine for me but as I try to acces to settings extension I get an error.

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

You may also check the output of GNOME Shell for any error messages.
This can be done with the following terminal command:

journalctl -f -o cat | grep -E 'burn-my-windows|'

## Expected Behavior
Extension works well for me but when I try access to settings I got an error (anexed screenshot)

## System
_Please complete the following information:_
 - Linux distribution : Ubuntu 20.04.3 LTS
 - Burn-My-Windows version : I cant find it.
 - GNOME Shell version: 3.36.8

log: 
The settings of extension burn-my-windows@schneegans.github.com had an error:

Gtk.BuilderError: .:12:43 Invalid property: GtkViewport.scroll-to-focus

Stack trace:

PreferencesDialog@/home/brath/.local/share/gnome-shell/extensions/[email protected]/prefs.js:37:19
buildPrefsWidget@/home/brath/.local/share/gnome-shell/extensions/[email protected]/prefs.js:99:16
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:13
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:175:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:5
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

![Captura de pantalla de 2021-12-15 17-49-14 png](https://user-images.githubusercontent.com/11011882/146230954-d4e96915-3642-41b3-9ce5-7bcee25184ad.png)

Describe the Bug

Effect doesn't seem to work right with Firefox. The window disappears and then the effect takes place. Happens with both the fire and matrix effects. Because I've only seen this happen on Firefox I am betting it's a problem there rather than here but reporting to both be aware and just in case there is some arcane fix that can be applied here.

Steps to reproduce the behavior:

1. open a Firefox window
2. close that window
3. window will disappear and then have the effect play

Expected Behavior

Window disappears piecemeal like the others do

System

Please complete the following information:

• Linux distribution: Fedora 35 Silverblue
• Burn-My-Windows version extensions.gnome.org version
• GNOME Shell version: 41.2

The Motivation

I installed this from extensions.gnome.org and it doesn't seem to do anything. I'm on Gnome 41, Ubuntu 20.04, 12-core Ryzen, GTX 1080.

The Solution

The requirements in the form of hardware and other packages, and/or settings that needs to be set up.

The Alternatives

I can not find any other solutions.

The Motivation

While the 500ms cap makes sense for the Burn or Matrix effect, a TV shuts off quicker than in 500ms as far as I am concerned, so the animation does not feel natural to me, even on the quickest setting.

The Solution

It would be nice to make it possible for the TV effect to have an animation time of 100-200ms. Maybe also lower the standard animation time for this effect

The Alternatives

• Lower the lower limit for animations in general
• For each effect, there can exist a parameter that dictates the lower limit for animation time. It may be 500 by default, but lower in the TVs case.
• Make the animation times abstract numbers instead of ms, with a multiplier for each animation type, such that a value of "1" in the matrix can mean 500ms, but in the TV effect be 100ms.

Thank you for your awesome extension :D

The Motivation

Right now when closing the window you clearly see where the letters start and animation ends, adding some bit of variance on the start/end position would make it the lines be blurred i think.

The Solution

I think adding a slider maybe that will add a bit of randomness when the letters start end for the columns.

The Alternatives

Maybe just add some random value for start end without a slider as a beginning.

Describe the Bug

When opening Emacs window and the toggle-frame-maximized is set to true the effect will froze and stays on the window permanently. See screenshot bellow.

When removing toggle-frame-maximized the behavior stops.

Steps to reproduce the behavior:

1. Install Emacs
2. Add following lines to ~/.emacs

;; Start maximised (cross-platf)
(add-hook 'window-setup-hook 'toggle-frame-maximized t)

3. Enable Burn My Windows extension
4. Open Emacs window

Expected Behavior

The effect will finish as when played on other windows

System

• Linux distribution [Fedora 35 Silverblue]
• Burn-My-Windows version [Burn-My-Windows 10]
• GNOME Shell version: [41.3]

The Motivation

Maybe relative to #60 : to understand better which aanimations are enabled you can consider to add an option
enable/disable in the respective settings page and remove the current selection from list in the general options page

The Solution

one image is better than 1000 words (just a mockup...)

in addition, the label of active animations could be in bold

The Alternatives

put the label of active animations in bold and leave how to choose animations as is..

Thanks
Andrea

After the x click, the window turns into a glowing dr. strange sign (rectangle) that then dissolves into individual dots.
If you don't know this movie, search for dr strange shield effect.

After clicking on close window the window turns into the green matrix letter salad which then falls to the ground.

Describe the Bug

All in activities overview:

• after you DND a window clone to another workspace, the clone isn't removed from the original workspace.
• after closing a window, the burn animation is performed, but the clone is not completely removed from the workspace overview, remaining window clones won't rearrange.

JS ERROR: TypeError: actor is undefined
_shouldDestroy@/home/user/.local/share/gnome-shell/extensions/[email protected]/extension.js:204:33

• switching to another workspace and back after closing a window will cause this error:

Object .Gjs_ui_workspace_WindowClone (0x557192ec8e40), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
== Stack trace for context 0x557191efe940 ==
#0   7ffde0259170 b   resource:///org/gnome/shell/ui/workspace.js:1398 (1ddc2da82268 @ 1925)
#1   5571929d8418 i   resource:///org/gnome/shell/ui/workspace.js:1246 (1ddc2da80d30 @ 213)
== Stack trace for context 0x557191efe940 ==
...

System

• Ubuntu 20.04 / X11
• Burn-My-Windows version 4
• GNOME Shell version: 36.6.9

It would be cool, if the settings dialog could be translated.

I congratulate you for the great job!
Can you develop a single extension that rags what were the most famous animations of compiz? (WOOBLY, CUBE, minimize, maximize etc. for example).

I don't think it's a good idea to make exclusive goodies for a product that has hurt Linux desktop adoption more than any FUD campaign. It's like making Hitler Time Magazine's "person of the year".

The Motivation

I saw that Pop Shell has this feature called "Floating windows exceptions" which disables "floating" of windows (tiling) based on app name.
Maybe "Burn-My-Windows" can have the same feature; to disable animation if application named X is minimized/closed (disable it, for example, on drop-down terminals or screenshot software ). I took a screenshot with Gnome Screenshot yesterday and because the delay of screenshot was 0 seconds, it got screenshot of screen along with Gnome Screenshot "burning" in middle of screenshot 😄

The Solution

Maybe make a list in Configuration of Burn-My-Windows in Extensions so we can add excluded application by name. For example, Pop Shell has it like this:

The list can be by just adding application name. It doesn't have to include this "select" feature of Pop Shell

The Alternatives

No alternative, just really nice extension 😺

New effect

Star Trek Transporter effect

The effect from TOS and/or TNG would be cool!

https://www.youtube.com/watch?v=KhODlALRGoA

The Motivation

In 90's, I used a funny Windows effect on Apollo AEGIS system. Its name was Tartine. Window dripped from top to bottom, like a slice of melted butter. I saw people put their hand under the screen! Could you add this effect?

The Motivation

When open the fire effect options tab, imo, it is not clear which preset is current active : selection widget show always the string "Choose a preset" : it doesn't matter which preset is chosen.

The Solution

replace the default string with the current preset applied (if there's one) or write "Custom preset" if someone change presets settings..

The Alternatives

Display a label somewhere with active preset or "Custom preset"

Thanks
Andrea

This extension works with GS 3.38 too.

But the prefs don't:
`Gtk.BuilderError: .:12:43 Invalid property: GtkViewport.scroll-to-focus

Stack trace:
PreferencesDialog@/home/steve/.local/share/gnome-shell/extensions/[email protected]/prefs.js:37:19
buildPrefsWidget@/home/steve/.local/share/gnome-shell/extensions/[email protected]/prefs.js:226:16
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17`

Right now, adding new effects is quite cumbersome. It would be great, if only one file needs to be added (and imported somewhere).

It would be cool if we could select the direction of the burning effect. Some possibilities:

• Top-down
• Bottom-up
• Left / Right
• Diagonally
• Circular from the pointer location