scalyr / cloudwatch2scalyr Goto Github PK

Per https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/, "improper usage of the Buffer constructor is still a path to insecure code inside an application".

I just followed the guide and got the logs coming over from CloudWatch to Scalyr, but this deprecation warning looks serious enough that I looked into a patch.

I have a PR ready, it's a very simple change to fix the issue but you should also update the .zip release.

Delete the file StreamingLogsfromCloudWatchtoScylr.pdf from the git repo.

Rationale:

• The file is redundant since it has the same contents as README.md. It adds little value since there is no reason for people to prefer a PDF over the much more convenient readme in the browser.
• Usually you do not want to have binaries under source control.
• Now my personal main reason: The existence of the PDF makes it harder for contributors to create pull requests for this repo. I am clueless how to generate the PDF, and therefore cannot update the docs properly in my PR.

Happy to include the deletion of the PDF in my other PR if you agree.

https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html
The last possible usage of that code was on April 30, 2019.

Do you have plans to update it for Node.js 10.x?