Comments (6)
For the investigation, can you try it with the Auth API Refactor branches ? maybe it fixes things, or maybe it would be the opportunity to fix it ?
from arsenal.
@DavidPineauScality yes probably solved in your pull request, because this line is wrong actually, res contain a field data, and that field contains signatureVersion and authType, so here we set values to undefined :)
from arsenal.
I agree with Alex. This fixes it -- https://github.com/scality/Arsenal/pull/119/files#diff-4046a881f95c5cd889f1b21f47ac0d40R114
Plus you return all of the info (including signature age) in the data object. What is the status on merging this?
Along with it we can merge a test in integration which uses a test with a sig version condition.
@nicolas2bert
from arsenal.
As far as I remember, it's pretty close to be Okay (at least for this first
step), but the ongoing GA effort is stalling that for now. Hopefully
mergeable next week ? I'll need your and alexandre's reviews, obviously.
On Wed, Sep 7, 2016 at 7:32 PM, Lauren Spiegel [email protected]
wrote:
I agree with Alex. This fixes it -- https://github.com/scality/
Arsenal/pull/119/files#diff-4046a881f95c5cd889f1b21f47ac0d40R114Plus you return all of the info (including signature age) in the data
object. What is the status on merging this?Along with it we can merge a test in integration which uses a test with a
sig version condition.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#154 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANpZZ1_iwVoBzNvu6wigFchN5aVdT5TKks5qnvUZgaJpZM4J2eur
.
David Pineau
Scality R&D Engineer
from arsenal.
@LaurenSpiegel Oh my bad... There's one issue...
UTAPI is now using Arsenal's API, so this needs a branch/PR Too....
from arsenal.
Fixed by #119
from arsenal.
Related Issues (20)
- multiple high and critical issues in `yarn audit` HOT 1
- empty/invalid/unredable/none Date header: errors incompatible with AWS
- invalid amz-date header: errors incompatible with AWS
- incorrect authorization header: errors incompatible with AWS
- authv4 sort query params HOT 1
- COMPAT: Increase Signature V2 Expires param
- COMPAT: return AccessDenied if Date before epochTime (01/01/1970) HOT 4
- callApiMethod in routes is not defined
- Error messages should not have periods
- Review of https://github.com/scality/Arsenal/pull/2152
- Re-review of https://github.com/scality/Arsenal/pull/2152
- Policy evaluation, action should be case insensitive
- Tests for #240 HOT 1
- delimiter.js maxKeys==0 param issue HOT 4
- Logs are broken HOT 6
- Exception occurs when using v4 authentication with certain query parameters
- Unbalanced log
- non monotonic clock used in version ID generation
- Action required: Greenkeeper could not be activated 🚨
- Invalid Greenkeeper configuration file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arsenal.