Comments (6)
This means that the tests did not catch a call to the validateAuthConfig
function. Fixing the way it's called should be enough.
from arsenal.
can you elaborate please? I actually did nothing on S3 side. Just rebuild the docker image.
from arsenal.
As you can see in https://github.com/scality/Arsenal/pull/314/files#diff-3730f90bb19d3b3646a968c2a4dddbdeL169 ; a project-wide change was made to werelogs to fix an insidious configuration bug; and led to a change in the API of a few common/library functions.
I may have missed some calls to this library in various projects, due to lack of automated testing and attention. If you find any, you may fix it following the method used in the same PR: https://github.com/scality/Arsenal/pull/314/files#diff-a400b2bf757d4e597747b3bd4a2105ddR33
from arsenal.
Alternatively, you may want to make sure you installed the proper versions of arsenal and werelogs, by removing your node_modules, and re-installing the dependencies (since we know npm doesn't handle git branches very well)
from arsenal.
After testing it out, I see it working (of course, you may need to rm -rf node_modules; then npm install ; before this works, as I described earlier).
That being said, I found out an obsolete piece of code in the S3 repository at https://github.com/scality/S3/blob/master/dataserver.js#L15 (The config bit about the logs in this line is not taken into account by Arsenal, so it might as well be removed). I'll leave the S3 team to handle this.
Then, Can we close this issue ?
from arsenal.
Sure. Closing.
from arsenal.
Related Issues (20)
- multiple high and critical issues in `yarn audit` HOT 1
- empty/invalid/unredable/none Date header: errors incompatible with AWS
- invalid amz-date header: errors incompatible with AWS
- incorrect authorization header: errors incompatible with AWS
- authv4 sort query params HOT 1
- COMPAT: Increase Signature V2 Expires param
- COMPAT: return AccessDenied if Date before epochTime (01/01/1970) HOT 4
- callApiMethod in routes is not defined
- Error messages should not have periods
- Review of https://github.com/scality/Arsenal/pull/2152
- Re-review of https://github.com/scality/Arsenal/pull/2152
- Policy evaluation, action should be case insensitive
- Tests for #240 HOT 1
- delimiter.js maxKeys==0 param issue HOT 4
- Exception occurs when using v4 authentication with certain query parameters
- Unbalanced log
- non monotonic clock used in version ID generation
- Action required: Greenkeeper could not be activated 🚨
- Invalid Greenkeeper configuration file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arsenal.