Comments (1)
One way to improve the situation here is by preventing "overtaking" updates. Suppose a project depends on two versions of scala-library:
"org.scala-lang" % "scala-library" % "2.12.13"
"org.scala-lang" % "scala-library" % "2.13.5"
Scala Steward checks each dependency individually for updates. It finds an update for the first dependency from 2.12.13 -> 2.13.5 but none for the second since that is already on the latest version. It then creates a PR for this update which is the reason for the bad PRs above.
I propose we discard the update because it "overtakes" the second dependency. An update is overtaking if there exists another dependency with the same groupId and artifactId but a version that is greater than the update's current version (2.13.5 is greater than 2.12.13) and smaller or equal to the update's next version (2.13.5 is equal to 2.13.5).
This will prevent updates of scala-library 2.12.13 until there is a newer 2.12 version available or the project removes the 2.13.5 dependency.
from scala-steward.
Related Issues (20)
- Email account and services
- Seemingly incorrect parsing of mill version HOT 3
- Move some of the verbose PR description instructions into PR comments HOT 3
- `tput: command not found` in scalafmt post-update hook HOT 3
- Version.Component.parse parses githash as separate components HOT 2
- Documentation for proxy configuration HOT 3
- per repo Configurable support for alwaysLatest version update selection strategy HOT 1
- Grouped PR description includes updates ignored via `// scala-steward:off` HOT 2
- JSON parse error "parent.full_name" on Bitbucket Cloud HOT 1
- Question: How to prevent upgrading Scala? HOT 2
- scala-cli updates not getting picked up HOT 3
- Haven't received updates from bot for a long time. HOT 1
- `StringIndexOutOfBoundsException` thrown when trying to perform `Substring.Replacement` HOT 4
- Post update hooks have no effect HOT 5
- Update branches via reset instead of reverting changes HOT 2
- Stewart try to update it as being another dependency HOT 3
- No able to create a pull request Bitbucket HOT 1
- sbt not found with scala-steward-action HOT 1
- no effect with .github/.scala-steward.conf override if PRs has been already created before HOT 2
- Scala Steward run within an org is incorrectly creating PR's against wrong repo HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-steward.