Comments (4)
Thanks for the report, @rtyley!
I think the following test is a reproduction of this issue:
diff --git a/modules/core/src/test/scala/org/scalasteward/core/edit/RewriteTest.scala b/modules/core/src/test/scala/org/scalasteward/core/edit/RewriteTest.scala
index dc1f33d7..ad8d874c 100644
--- a/modules/core/src/test/scala/org/scalasteward/core/edit/RewriteTest.scala
+++ b/modules/core/src/test/scala/org/scalasteward/core/edit/RewriteTest.scala
@@ -942,6 +942,15 @@ class RewriteTest extends FunSuite {
runApplyUpdate(update, original, expected)
}
+ // https://github.com/scala-steward-org/scala-steward/issues/3206
+ test("".only) {
+ val update = ("com.typesafe.play".g % "play".a % "2.9.0" %> "3.0.0").single
+ .copy(newerGroupId = Some("org.playframework".g), newerArtifactId = Some("play"))
+ val original = Map("build.sbt" -> """ "com.typesafe.play" %% "play" % "2.9.0" """)
+ val expected = Map("build.sbt" -> """ "org.playframework" %% "play" % "3.0.0" """)
+ runApplyUpdate(update, original, expected)
+ }
+
private def runApplyUpdate(
update: Update.Single,
files: Map[String, String],
It looks suspicious that the newerArtifactId
is the same as the old artifactId instead of None
.
from scala-steward.
This should be fixed by #3207.
from scala-steward.
This should be fixed by #3207.
Thank you @fthomas ! I can see that this was released with v0.27.0, and running a Scala Steward job this morning with v0.27.0 and play-secret-rotation
once again included in the run, I can confirm the job successfully processed the repo - great work, thank you!
from scala-steward.
Good to hear that it is working now and thanks for reporting back!
from scala-steward.
Related Issues (20)
- Haven't received updates from bot for a long time. HOT 1
- Post update hooks have no effect HOT 5
- Update branches via reset instead of reverting changes HOT 2
- Stewart try to update it as being another dependency HOT 3
- No able to create a pull request Bitbucket HOT 1
- sbt not found with scala-steward-action HOT 1
- no effect with .github/.scala-steward.conf override if PRs has been already created before HOT 2
- Scala Steward run within an org is incorrectly creating PR's against wrong repo HOT 3
- [Bug?] Cannot resolve -p with Mill 0.11.6 HOT 8
- Option to abort on scalafix migration failure HOT 1
- Using custom dependency rules for scalafix-migrations with 'type: "build"'
- Scala Steward runs as root when using the published Docker image (but it probably shouldn't)
- Unable to respect update frequency when version number is stored as a val
- Scala Steward attempting to raise PRs for group branches that already have PRs HOT 3
- Force-pushing over modified branches HOT 5
- Avoid pushing scala updates for non LTS versions HOT 6
- Automatic `buildRoots` detection
- Bitbucket repository name is malformatted in URL
- Clarification of "updatePullRequests" for grouped PRs HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-steward.