ipfs-http-client should not be in the list of dependencies that is excluded from eager bundling by vote. See the vite.config.ts file:

Update the excludeDeps array and remove ipfs-http-client

The app will compile and run as-is, but if you try to use ipfs-http-client, it'll cause a runtime error.

Describe the bug
Local balance is not showing

To Reproduce
Steps to reproduce the behavior:

1. yarn start
2. go to web page
3. view balance

Expected behavior
My local balance to show

Screenshots

• related to #56
• need a way to guide new users from file to file with comments
• perhaps creating youtube video

Describe the bug
When you click send for setPurpose you get an error

To Reproduce

1. Try to set a new purpose

Expected behavior

1. for the tx to go to metamask for confirmation
2. tx to complete successfully updating the purpose

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

Describe the bug
Using metamask, if you switch networks while connected, an error is thrown. The app goes unresponsive, and a page refresh is required

To Reproduce
Steps to reproduce the behavior:

1. Use Meta Mask as a provider
2. Connect your wallet
3. Switch networks in Meta Mask

Expected behavior
Network switch should be handled gracefully

Screenshots

Fix the readability of the text

Originally posted by @codenamejason in #6 (comment)

• see related case: scaffold-eth/eth-ui#96

This is related to : scaffold-eth/eth-ui#35

1. the app has injectedProvider and local provider
2. any of them can be passed into different functions creating some confusing combination of defined and undefined variables
3. once the related case is done, move logic into app and change how providers work in the app.

This happens when requesting funds from the faucet using the burner wallet using the 'get funds from faucet' link, other wise using the wallet icon for the faucet it works.

Originally posted by @codenamejason in #6 (comment)

now that 0.2.0 is out with eth-hooksv3 and eth-componentsv2

• we want to clean up the types for new devs
• add comments
• remove any friction to getting started

I'm using Moralis as a backend for a Meta MultiSig Factory App.

One of the dependencies is react-moralis, which in turn uses the moralis, which in production throws an error.

I suspect that this is due to how vite builds the app for production.

I've searched for this particular issue and could not find it related to Moralis specifically, but I did find it related to Vue and Rollup. However, none of the solutions there were applicable.

So I have little hope that the Moralis people will be able to solve this, but @ShravanSunder I know you've given quite a bit of thought to the vite config and the bundling process. So - here it is:

Issue Description

The app works in local development.

But when served as a production bundle it throws the following exception

Here is the stack trace

This is my code in useMultiSigSafes.tsx:

This is in Cloud.js line 98:

This is also Cloud.js line 171:

This is encode.js line 149:

This is encode.js line 65:

This is my vite.config.ts:

import { resolve } from 'path';

import reactPlugin from '@vitejs/plugin-react';
import { defineConfig } from 'vite';
// import reactRefresh from '@vitejs/plugin-react-refresh';
import macrosPlugin from 'vite-plugin-babel-macros';
import { viteExternalsPlugin } from 'vite-plugin-externals';
import tsconfigPaths from 'vite-tsconfig-paths';

const isDev = process.env.ENVIRONMENT === 'DEVELOPMENT';
console.log('env.dev:', process.env.ENVIRONMENT, ' isDev:', isDev);

/**
 * browserify for web3 components
 */
const externals = {
  http: 'http-browserify',
  https: 'http-browserify',
  timers: 'timers-browserify',
  electron: 'electron',
  'electron-fetch': 'electron-fetch',
};

const nodeShims = {
  util: 'util',
};

/**
 * Externals:
 * - node externals are required because web3 are terribly bundled and some of them use commonjs libraries.  modern libs like ethers help with this.
 * - electron:  added due to ipfs-http-client.  it has very poor esm compatibility and a ton of dependency bugs. see: https://github.com/ipfs/js-ipfs/issues/3452
 */
const externalPlugin = viteExternalsPlugin({
  ...externals,
  ...(isDev ? { ...nodeShims } : {}),
});

/**
 * These libraries should not be egarly bundled by vite.  They have strange dependencies and are not needed for the app.
 */
const excludeDeps = ['@apollo/client', `graphql`];

export default defineConfig({
  plugins: [reactPlugin(), macrosPlugin(), tsconfigPaths(), externalPlugin],
  build: {
    sourcemap: true,
    commonjsOptions: {
      include: /node_modules/,
      transformMixedEsModules: true,
    },
    rollupOptions: {
      input: {
        main: resolve(__dirname, 'index.html'),
      },
    },
  },
  esbuild: {
    jsxFactory: 'jsx',
    jsxInject: `import {jsx, css} from '@emotion/react'`,
  },
  define: {},
  optimizeDeps: {
    exclude: excludeDeps,
  },
  resolve: {
    preserveSymlinks: true,
    mainFields: ['module', 'main', 'browser'],
    alias: {
      '~~': resolve(__dirname, 'src'),
      ...externals,
      ...nodeShims,
      process: 'process',
      stream: 'stream-browserify',
    },
  },
  server: {
    watch: {
      followSymlinks: true,
    },
    fs: {
      // compatability for yarn workspaces
      allow: ['../../'],
    },
  },
  css: {
    preprocessorOptions: {
      less: {
        javascriptEnabled: true,
      },
    },
  },
});

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. yarn start
2. go to web page and click connect to connect your wallet

Expected behavior
Open wallet connect modal

Screenshots

Desktop (please complete the following information):

• OS: OS
• Browser: chrome

Additional context
Add any other context about the problem here.

Something weird going on here.. the address for the DAI contract is the burner wallet address and the DAI contract is not showing.

Originally posted by @codenamejason in #6 (comment)

Describe the bug
Some of the text is hard to read

To Reproduce
Steps to reproduce the behavior:

1. Go to any page

Expected behavior
Clear readable text

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

The check for target network validity throws an error whatever the condition

It's not the expected behaviour of invariant. It doesn't affect execution but may be confusing to developers.

Happy path (Should log no error)

Sad path:

I guess we could at least leave a comment, but even better would be to check beforehand and do smth like

const validTargetNetwork = NETWORKS[targetNetwork] != null;
if (!validTargetNetwork) {
  invariant.error('Invalid target network: ', targetNetwork);
}

This way we'd not have false alarm

Ethers does not allow network change as it does a check and freezes the provider object

• see ethers-io/ethers.js#866
• the recommendation is to reload, however I don't think its very user friendly
• the idea is to have an option in ethersConnector to do this

Describe the bug
Not showing the gas price correctly

To Reproduce

1. Run app

Expected behavior
Show correct gas price

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

May have to fix all the errors and warnings in app

• fix bugs that are found

Describe the bug
The addresses are not the same and incorrect in the wallet

To Reproduce
Steps to reproduce the behavior:

1. run local chain
2. log in with metamask
3. use the wallet on the faucet

Expected behavior
The addresses to be the same

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

Describe the bug
gas is showing a question mark

To Reproduce
Steps to reproduce the behavior:

1. yarn start
2. got to web page

Expected behavior
to show the gas price

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I am not sure how important it is to show the gas on localhost and local chain...

...TBD... to be done after #23

Related Epics

• scaffold-eth/eth-contract-warehouse#1

Overview

• a package that acts like a contract repository for common and vetted contracts
• makes it easy new developers to use existing contracts with scaffold-eth
• removed the need for a billion branches in scaffold-eth

• #26

Describe the bug
Trying to install this repo using "yarn install", but an error is thrown and no node_modules are installed.

To Reproduce
Steps to reproduce the behavior:

1. cmd> gh repo clone scaffold-eth/scaffold-eth-typescript
2. cmd> yarn install
3. See error: "gluegun@... The remote archive doesn't match the expected checksum"

➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 320ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ yargs@npm:4.8.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yn@npm:3.1.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yocto-queue@npm:0.1.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ zod@npm:3.11.6 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ gluegun@https://github.com/edgeandnode/gluegun.git#commit=b34b9003d7bf556836da41b57ef36eb21570620a can't be
➤ YN0018: │ gluegun@https://github.com/edgeandnode/gluegun.git#commit=b34b9003d7bf556836da41b57ef36eb21570620a: The remote archive doesn't match the expected checksum
➤ YN0000: └ Completed in 46s 682ms
➤ YN0000: Failed with errors in 47s 8ms

Expected behavior
Installation using [email protected] should complete without errors and node_modules should be downloaded and built correctly.

Screenshots
See attached screenshot.

Desktop (please complete the following information):

• OS: Windows 11 Pro
• Terminal: cmd.exe as Administrator
• Browser: n/a
• Version: 21H2 (build 22000.527)

Smartphone (please complete the following information):
n/a

Additional context
Also attempted in Windows PowerShell as a regular user (non-Administrator), but same failure.

Describe the bug
When I run yarn surge to publish the front end, the app won't run. I get this error:

To Reproduce
Steps to reproduce the behavior:

1. Check this branch: https://github.com/scaffold-eth/scaffold-eth-typescript-challenges/tree/challenge-0-eth-hooks-upgrade
2. Publish the front end with yarn surge

Additional context
I'm stumped, it seems related to the node-fetch package, but I can't figure out what's causing the error

Add auto refresh when you deploy new contracts, this is a key feature with Scaffold-Eth

GraphiQL v1 cannot be loaded by dynamic import. It has been disabled. see:

• graphql/graphiql#1643
• graphql/graphiql#1606

Solutions

• For now this has been disabled until we find an alternative client or GraphiQL v2 will be released
• we could also have a separate project that just launches as a package in scaffold eth

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Clone repo
2. Run yarn chain
3. Run yarn deploy-and-graph
4. See error

Expected behavior
Shouldn't throw error

I guess it need to tell which package/CLI install on this repo or install globally with npm/yarn

Describe the bug
http://localhost:3000/exampleui throws an error

To Reproduce

1. Click the Example UI tab

Expected behavior

1. To render page

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

Using the release branch with commit b0efc7e

Deployed contract on rinkeby.

0. Open App, Open Web3 Modal
1. Choose WalletConnect, scan QR code from phone's metamask
2. Logout
3. Open Web3 Modal, choose WalletConnect

Now, instead of the QR Code window appearing, it directly reconnects to the previously connected account (the phone's metamask)

At least, it appears to be that way. Upon logging out again, I see:

Upon Login + choose WalletConnect, I see:

Describe the bug
Mainnet DAI not showing

To Reproduce
Steps to reproduce the behavior:

1. run the app

Expected behavior
The DAI contract should show

Screenshots

Desktop (please complete the following information):

• OS: iOS
• Browser: chrome

Additional context

• make config easier to understand. see .env changes in #65
• #66
• scaffold-eth/eth-ui#133

need to find a solution for building mixed es6 and commonjs files due to web3-provider-engine.

See:

• talks about issues with vite/webpack5/snowpack: WalletConnect/walletconnect-monorepo#341
• portis-project/web-sdk#75
• aragon/use-wallet#73
• WalletConnect/walletconnect-monorepo#310

Notes:

Shravan, [04.10.21 16:42]
looks like the web3-provider-engine is a problem in many places

Shravan, [04.10.21 16:42]
portis-project/web-sdk#75

Shravan, [04.10.21 16:42]
WalletConnect/walletconnect-monorepo#310

Shravan, [04.10.21 16:42]
aragon/use-wallet#73

Shravan, [04.10.21 16:43]
i think it impacts webpack 5 as well. mostly because walletconnect depends on web3-provider-engine and its not maintained

Shravan, [04.10.21 16:46]
i think the solution is to use esm imports for any external providers like wallet connect, portis etc

When I was updating the challenges with eth-hooks-v4, I noticed that all of my hardhat generated files were being added as modified files in my git changes.

I think we want to exclude everything in packages/hardat-ts/generated

Describe the bug
The output of the accounts script always shows 0 for the account balance

To Reproduce
Steps to reproduce the behavior:

1. Generate a deployer account with yarn generate
2. Fund it
3. Run yarn accounts
4. Look at the output of the command, the balance shows 0

Expected behavior
The balance should reflect the actual balance of each network

Describe the bug
I added the ipfs-http-client package, and when running yarn start there's an error trying to load electron. If you look at that stack trace, the package has a dependency that tries to load electron via require.

To Reproduce
Steps to reproduce the behavior:

1. Checkout this branch: https://github.com/scaffold-eth/scaffold-eth-typescript-challenges/tree/challenge-0-simple-nft
2. Run yarn & yarn start

Expected behavior
Packages that use common js shouldn't cause a runtime failure

Additional context
I tried configuring @originjs/vite-plugin-commonjs, but I still had the same error

https://github.com/orgs/scaffold-eth/projects/2#card-69883528

Summary

• Related to #41

Tasks

• Integrate fix from scaffold-eth/scaffold-eth-typescript-challenges@7d761c4 into master
• Integrate fix from scaffold-eth/scaffold-eth-typescript-challenges@7d761c4 into develop

i cloned the repo ( "version": "0.1.0-beta02" )

• yarn
• yarn start
• yarn chain

Im getting following error on localhost

Uhoh! There was an error!
Error: Invariant failed: You should not use outside a
at invariant (http://localhost:3000/node_modules/.vite/chunk-53OEHZQQ.js?v=68700035:11:9)
at http://localhost:3000/node_modules/.vite/react-router-dom.js?v=68700035:2039:24
at updateContextConsumer (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:13792:27)
at beginWork (http://localhost:3000

...

ost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:3671:22)
at Object.invokeGuardedCallbackDev (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:3696:24)
at invokeGuardedCallback (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:3730:39)
at beginWork$1 (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:17077:15)
at performUnitOfWork (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:16305:20)
at workLoopSync (http://localhost:3000/node_modules/.vite/chunk-KSPOQUED.js?v=68700035:16259:13)

Problem is with vite version 2.6.12, upgraded it to 2.6.14 ( latest one ), after upgrading it is showing blank screen some other issues with node modules

After successfully running the app deployed on rinkeby from localhost, I deploy to surge but can't connect the wallet.

The web3 modal does not open, there are errors in the console:

What I gather is that the app tries to retrieve the chainId with a call to localhost:8545, even though it is configured with the targetNetwork rinkeby:

I've performed a clean walkthrough of the getting started steps with the latest from release (0.2.0).

install, chain, contracts:build, deploy, start

Vite-app won't start at all.

Browser just loading with an empty page

Vite output:

No output at all in the browser console

add networks to hardhat.ts, network.ts

• maybe make a common project that's a lib for shared models
• make it easy to make tabs, menu and remove your contract
• remove main menu
• rename contractsConnector.config. to appContracts.config
• contractConnectorConfig, udpate abi example

   LENS_HUB: createConnectorForExternalAbi(
       'LENS_HUB',
       {
         [TARGET_NETWORK_INFO.chainId]: {
           address: '0x7c86e2a63941442462cce73EcA9F07F4Ad023261',
           chainId: TARGET_NETWORK_INFO.chainId,
         },
       },
       abi
     ),
   } as const;	

• what is tuple vars? and how do we show contract data fo rit
• i've changed yarn contract build
• change matic gas price
• load tasks from the tasks folder

   (<if (!process.env.SKIP_LOAD) {
   	glob.sync('./tasks/**/*.ts').forEach(function (file) {
       require(path.resolve(file));
     });
   }>)	

• turn on esModuleInterop in hardhat-ts
• update lint for tasks
• rename connector config to appContracts.config
• notes and updates on external contract abi loading
• add tenderly to hardhat
• add vite plugin checker !important
• add hardhat faucet
• moved the refactored tasks
• add shx to hardhat, well the whole app
• hardhat compiling needs a tag
• remove console.log from deployment GitHub - wighawag/hardhat-preprocessor: An hardhat plugin to pre-process contract source code before compilation
• hardhat
  • documenation system:
    • @primitivefi/hardhat-dodoc - npm
    • hardhat-docgen - npm
  • data and inspection
    • hardhat-storage-layout - npm
  • dev exp
    • hardhat-watcher - npm

The main app page is too large, break it up into smaller components to make it easier to understand and maintain.

Path to npm packages & typescript

This project will be used to coordinate the path to typescript npm packages

• eth-components
• eth-hooks
• eth-contract-warehouse

Current Milestones

eth-components v1

Moving things into library: everything stays the same for max compatibility. use typescript.

• scaffold-eth/eth-components#2
• scaffold-eth/eth-components#6

eth-hooks v2

Already released, typescript. continue some basic testing and bug fixes

Using React Context: eth-hooks v3 and eth-components v3

Initial changes for context

eth-components v2: a context via react-web3 to pass around the ethers provider
eth-hooks v3: a context via react-web3 to pass around the ethers provider. Modify tests and add more tests

• scaffold-eth/eth-ui#50
• #5
• #4
• #3
• #1
• scaffold-eth/eth-components#9
• scaffold-eth/eth-components#12
• scaffold-eth/eth-components#13

Unit testing eth-hooks

• scaffold-eth/eth-ui#77
• scaffold-eth/eth-components#16
• scaffold-eth/eth-components#14
• scaffold-eth/eth-components#10

scaffold-eth-typescript context

• #25

• option to autoconnect to burner
• fixed error messages for transaction to show actual error
• bug fixes with string showing up as [string]