Giter Club home page Giter Club logo

brewdb's Introduction

Hi ๐Ÿ‘‹, I'm Samir L. Boulema

A passionate backend developer from The Netherlands

  • ๐Ÿ”ญ Iโ€™m currently working on CodeNav

  • ๐Ÿ‘ฏ Iโ€™m looking to collaborate on RepoZ

  • ๐Ÿค Iโ€™m looking for help with TGit

  • ๐Ÿ‘จโ€๐Ÿ’ป All of my projects are available at https://github.com/sboulema

  • ๐Ÿ’ฌ Ask me about C#

  • ๐Ÿ“ซ How to reach me [email protected]

  • ๐Ÿ“„ Know about my experiences https://www.sboulema.nl

  • โšก Fun fact I brew my own beer ๐Ÿบ

Connect with me:

Linktree

sboulema

brewdb's People

Contributors

phillc73 avatar sboulema avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

brewdb's Issues

[Suggestion] Add New Columns to Yeast Table

I'd like to propose adding the following columns to the Yeast table:

  • Form: Dry or Liquid
  • Strain: saccharomyces cerevisiae or kveik or brettanomyces etc
  • Flocculation: High, Medium or Low
  • Styles: E.g. "Complex full bodies Porters, Stouts and Ales"

[Suggestion] Additional Columns to Malt Table

I was thinking that there could be some additional useful columns added to the Malt table.

While EBC and Yield are already included, other useful information would be:

  • Grain Type - Barely, Wheat, Oats, Rye etc. Maybe this is already covered in the Name field
  • Row. Barley being the most common grain is either mainly 2-row (EU) or 6-row (US). Could be handled in a lookup table potentially.
  • Moisture Content (a percentage)
  • Diastatic Power in ยฐWK (Windisch-Kolbach units)
  • Total Protein (a percentage)
  • Total Soluble Nitrogen (a percentage)
  • Friability (a percentage)

This article has some background.

I would just hate to add a whole bunch of malts and then discover that a lot of useful information was missing and everything needs an update.

Also, I'm not clear from the description in the Contributing.md guide, but is the Yield field Extract Yield (% DBFG)?

[Suggestion] Additional Info for Hop Table

As I've been adding new hops varieties to the database, I am often finding additional information which could perhaps be standardised in their own columns.

For example:

  • Crop yield per hectare
  • Harvesting time - early, middle or late, although some varieties cross these boundaries so I'm not sure a lookup table approach would work
  • Predominant growing region - some varieties which don't have a country designation in their Name field can still be predominantly grown in only one country or region

Adding these columns would have an impact in that already included hop types would need the information back filled.

The other question is how useful this information is. Which in turn links to the target audience for the database. If the audience is only homebrewers, then perhaps the above three pieces of information are not so important. If the audience is broader and more general, then I think the additional fields would be useful.

Yeast

What about a distinction between beer yeast, bacteria, brettanomyces?

Contributing Guidelines

I was wondering if it's worth publishing a few contributing guidelines, to cover such things as the db architecture, but also specifically the format for data entry.

For example from the Hops table:

  • Some entries have a country designation after them. What are the guidelines for using this? Should all new entries have a country designation? Should older entries be updates where possible? E.g. Fuggles (GB)

  • What are the guidelines for completing the Trade field? How does that differ from the Info field?

Or for the Malts table, if two different maltsers have a product named exactly the same, e.g. Pale Malt, should they always be separate entries?

I appreciate it's a bit of effort to write something like this, but I think it would be helpful for new contributors, to insure data consistency and that pull requests are more likely accepted.

Other Databases

I am not super well versed in databases but is it possible to make this available to other databases outside of sql lite, such as MariaDB, postgres, etc?

[Suggestion] Make Malt EBCmin and EBCmax Nullable

Currently the columns EBCmin and EBCmax are not nullable. This means that any grain or malt where an EBC entry is not available, cannot be added to the database.

For example, all the cereals offered by Crisp - Torrified Wheat, Oats, Corn, Rice have no EBC values.

Nor does the special floor malted Maris Otter grain.

Nor, generally, do the distilling malts. I guess it's a question of whether these should be fundamentally included in the database. My opinion is that they should for completeness.

@sboulema Could I ask you to make this change please? And at the same time check the integrity of the Malt table? TablePlus is the tool I'm using for updating and it is fine with things, but I checked in sqlitebrowser and it wants to throw some errors.

Hop Type

Have you thought about having hop type as part of the table? It could be a lookup on another table to say if the hop is whole, pellet, extract, etc.

[Data Source] Additional Hops Varieties

Links to a few websites where I spotted some additional hops varieties not yet in the db

Where there is a discrepancy in data, for example difference alpha-acid ranges, data from Hopsteiner is being preferentially used.

Hopslist generally provides Style information.

Both can provide Substitute information.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.