sblakemore / cleanflight Goto Github PK

@sblakemore
This one is minor.
It may be a matter of taste, but the vtx command resembles to me something more broad and powerful(?) than aux switch definitions; like the serial command specifying device configuration.
I'm more comfortable with "vtxaux", but since the change causes compatibility problem for existing users of the singularity fc, I would leave the decision up to you.

@sblakemore
I saw your work on separation of device independent things in io and drivers directory, which was on my work list also. Upon doing so, you have created vtx.[ch] in both io and drivers directory.

Why don't we change the ones in io directory to vtxrc.[ch]? They avoid name collisions, and better express what is inside of them, imo.

It may also be nice to change function/object names in these files from vtxXXX() to vtxRcXXX() for more clarity.

@sblakemore
My initial use case was for micro builds where lots of people still use F1s in which space is a premium. For such targets, it would be nice to have an option to drop RC-based control and just use CLI variables to choose a TX frequency.

The option would be called VTXRC. Without VTXRC, init() will just call a VTX initialization function where the TX frequency is statically decided from vtx_{mode,band,channel,mhz}. With VTXRC, full RC-based control will be compiled in.

@sblakemore
I understand that you have introduced function pointers and a container for the pointers vtx_t to handle entry points into device dependent functions.

While it is cool, I can't think of the use case in which hardware and software (bit-banged) SPI co-exists and the software selecting them dynamically upon initialization.

Some compile time option, say VTXSPI and VTXBB would suffice, imo.

Do you have a use case of simultaneous hardware and software SPI?

@sblakemore
Is there any pointer to publicly available bare vtx module with power control?

IIRC, I have seen standalone modules that switch between two power levels, but not the bare RF module.

I'm also interested in how we can power on/off the RF module. There's a PA control register in RTC6705, but manipulating bits in the register do nothing; there may be a correct sequence?
An external facility such as solid state relay, or pololu 's -SHDN equivalent in the regulator circuit?

Take a look at my branch vtx-integration-with-vtxcustom at
https://github.com/jflyper/cleanflight/tree/vtx-integration-with-vtxcustom
when you have a spare time.