savaughn / pokerom-trader Goto Github PK

currently in Library. Move to Library/Application Support/PokeromTrader

Describe the bug
When trading crystal to crystal there is a restriction on all pkmn.

To Reproduce
Steps to reproduce the behavior:
Trade -> select 2 crystal files

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

language select option

It'd be nice to see the save file data in addition to the filename such as on pokemon stadium

If a string is less than 10 chars, then any unused chars are rendered in-game as a ?.

Minimum Example

    char tmp_nickname[11];
    pksav_gen2_import_text(save->pokemon_storage.p_party->nicknames[0], tmp_nickname, 10);
    pksav_gen2_export_text(tmp_nickname, save->pokemon_storage.p_party->nicknames[1], 10);

when mail is opened on a pokemon received the mail is full of question marks.
If the pokemon is traded back to the OT, then the mail is readable again.

Is your feature request related to a problem? Please describe.
build libpksav.a instead so that I don't have to bundle it with executables

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Give any party pkmn pokerus

The app won't launch unless you first make the executable executable in the package contents

Implement Bill's PC to move between boxes and party so that you don't have to load in game first.

STR
download pokeromtrader from artifacts
chmod +x pokeromtrader in package contents
add saves folder with saves in the same folder as the executable in package contents
open app -> select trade
see crash

cut out all unnecessary library code from pksav and raylib to help reduce executable size

• remove all gen 4+ code from pksav

^

trade exp boost

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

view all dvs of each party member.

re-roll dvs / generate new stats

all of the code is present to make this possible.

Describe the bug
the atk is 0 on a level 100 pkmn. I think the source save file is a hacked file so it might just be off.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

all stats in pkmnstats.h need to be double checked for accuracy

current res 800x400
support 720p

just needs some graphical updates

on trade should generate new IVs and update stats

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

They need to updated in trainer data

Branch windows-build-test

Build fails with linker failing to find pksav functions from pksavhelper

Describe the bug
This is a hold-over from development. Make ESC key back navigate, then quit on main menu.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Looking for something with color

maybe red/white background with yellow reactive menu buttons

Generic trainer art

No official pokemon art should be used in this project to avoid copyright infrigement

make it better

they are incorrectly listed on the trade screen.
Resulting trades in game have the correct id.

technically possible with pksav

struct pksav_gba_save *gen3_save;
struct pksav_gba_pokemon_party *pkmn_party = &gen3_save->pokemon_storage.p_party;
struct pksav_gba_pokemon *pkmn_1 = &pkmn_party->party[0];

cwd in IDE points to folder with executable, but release builds cwd points to user/{username}.

Add a way to define a path

make it better

I need someone to run the intel-based artifacts and report back. I only have an M1.
https://github.com/savaughn/pokerom-trader/suites/16764383826/artifacts/957354406

Build artifacts bundles the libpksav.dylib in the frameworks folder for app bundling, but breaks if you attempt to execute the artifacts directly.

download an artifacts zip not an app bundle.
attempt to execute pokeromtrader
see lib error

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. settings
2. reset to defaults

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
trainer name "CRYSTAL" is too long, and the L overhangs the box when details pane is closed. both left and right boxes.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

with file versioning and trade log

• build pksav for switch
• import raylib-nx
• controller support
• filesystem support
• asset bundling

currently both save files need to be the same generation.

the data exists in parties.asm

Trade with any NPC or maybe just gym leaders / oak / red

Describe the bug
truncate file names that are too long for SaveContainer component.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

It's not supported yet. If you try, then it will trade, but mess up your data. You can trade back though 🤷

Is your feature request related to a problem? Please describe.
app icons for windows, linux, macos

• build raylib for windows arm (glfw issues)

Describe the bug
silver is considered invalid
crystal <> crystal is marked as cross-gen

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
if you change the saves directory while the app is open and navigate away from file select and back to it, then the names will shift.

reset save_file_data on navigation to file select screen

it resets to saves/ on start up and will not remember the previously used save files folder.