Giter Club home page Giter Club logo

Comments (13)

jcarroll2007 avatar jcarroll2007 commented on August 13, 2024

Emulating this in the browser does not yield the same result

from stem.

sathomas avatar sathomas commented on August 13, 2024

Some suggestions for this one.

  1. Obvious first step is to tether an android device (or remote debug it) and check the dev console. If we're lucky, there will be an error message. (Doesn't seem likely though.)
  2. The multiple maps with hundreds of markers is a definite performance problem. (I've tried to argue for a more efficient approach, but to no avail so far.) If the android device is relatively low powered, that could be the cause of the sluggishness. How does the site perform if you just scroll down to the maps instead of using the menu?
  3. Might there me a conflict between the browser's handling of URL fragments (e.g. #admins) and the Backbone router? Try commenting out the explicit routes in app.js and see if that clears up the problem.

from stem.

gscoppino avatar gscoppino commented on August 13, 2024

I was able to reproduce on production using the latest Chrome stable for Android. I'm also getting the same problem on production using Chrome dev tools (latest stable) to emulate both an iPhone 5 and Nexus 5. I didn't receive any errors from the console and there were no pending requests on the network tab of Chrome dev tools. It does NOT occur for me in latest Firefox, Firefox in responsive design mode, Internet Explorer 10, or Internet Explorer 10 with IE9 user agent.

jcarroll2007, Were you emulating in Firefox when you were unable to reproduce the results? If so, this could be a Chrome/Webkit bug. I do not have access to Safari to test there, unfortunately.

For reference, Building and running the latest sathomas/master locally, the bug no longer occurs, in any of the browsers referenced (except Safari which I have not tested), in any of the configurations referenced.

-- Giuseppe

from stem.

gscoppino avatar gscoppino commented on August 13, 2024

sathomas: Number 2 is probably not the case since it happens in Chrome dev tools on a desktop with mid-range PC specs.

-- Giuseppe

from stem.

sathomas avatar sathomas commented on August 13, 2024

That's weird. master is exactly what's running in production. (At least it should be :) Both were updated this morning.

Just for sanity, can you try three things:

  1. The latest master built and running locally.
  2. The latest production.
  3. The 1.0.4 release (This will be the "built" version of master) locally.

In theory, all three of those should be identical. If they're not, that could be a clue.

from stem.

gscoppino avatar gscoppino commented on August 13, 2024

I can only reproduce the problem in the latest production. 1.0.4 and master do not have the issue in Chrome dev tools. I haven't tried either 1.0.4 or master directly on a phone.

My bad, this was just a configuration thing, probably because I forgot to run grunt clean and grunt build. See below comment.

from stem.

gscoppino avatar gscoppino commented on August 13, 2024

I went and cloned upstream directly rather than just pulling your master into mine, and with fresh builds, it is now its reproducible for me in 1.0.4 and master as well.

from stem.

sathomas avatar sathomas commented on August 13, 2024

As best as I can tell:

  • If you load the site in desktop Chrome and then switch to responsive view in the developer tools, then the bug doesn't occur.
  • If you switch Chrome to responsive view before loading the site, the bug occurs.

Also, once the initial "dead time" clears, I have to quit and reload Chrome to get it to happen again.

If anyone has any contrary experiences, chime in. Unfortunately, though it appears that I can reliably reproduce the bug (using the second procedure), I'm not seeing any clues as to its cause. During the "dead time", the browser is 99.43% idle, memory use is not excessive, and no network requests are occurring.

from stem.

sathomas avatar sathomas commented on August 13, 2024

Think I've found the problem. For some reason, Chrome on Android isn't repainting when the section positions are swapped. The "dead time" is apparently just a random amount of time until the browser decides to repaint. I can't think of any reason that's not a bug in Chrome, but haven't had the time to research it yet. In the meantime, I'm working on a quick fix.

from stem.

sathomas avatar sathomas commented on August 13, 2024

Fix is now live in production. @jcarroll2007, @gscoppino can you guys verify as well? I don't trust my own testing completely.

from stem.

gscoppino avatar gscoppino commented on August 13, 2024

I'm not longer able to reproduce the problem in Chrome on Android or in Chrome device mode :)

from stem.

sathomas avatar sathomas commented on August 13, 2024

Sweet. Gonna close the issue then.

from stem.

jcarroll2007 avatar jcarroll2007 commented on August 13, 2024

Working for me as well!

from stem.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.