Need outline styles for buttons about stem HOT 7 CLOSED

Just out of curiosity - why is the class invite__button being used to override the button themes? This seams redundant. Since .btn already exists, why not use that class?

from stem.

it's a holdover from the early implementation, and you're right; it shouldn't be needed.

from stem.

Ok, cool. I'll clean those up.

One other small note - Due to the fact that the standard buttons don't have borders, the height and width of the standard buttons, compared to the transparent buttons, is 4px less (because of the 2px border on each side).

Example: (It's also a bit strange that the transparent button is rendered slightly above the standard one). This image was taken from the updated docs on my branch

Of course, this can be fixed, just let me know if it is important enough to tackle. I briefly tried to add a border to all buttons to keep the size consistent, but this caused other styling issues.

from stem.

Good to check, and it's definitely not acceptable for the buttons to have different sizes. Seems like it ought to be simple enough to give the default btn class a transparent border and then adjust as appropriate for themes. Also looks like the margins and/or padding needs adjustment to vertically center the button text.

from stem.

OK, I fixed the border and vertically centered issues. Would you like me to remove the invite__button class and all other unnecessary classes? (results-main__button, results-secondary__button etc.)

from stem.

that would be great

from stem.

incorporated from PR

from stem.