satelliteqe / katello-rapidnode Goto Github PK

rapidnode currently has zero error checking, it will continue to go its happy way if stuff doesn't work. For example, if you've not got your repos set up right, it will try to create envs and sync even if capsule installer never gets installed.

At a minimum

• check to assure capsule-installer has installed and returns no error upon execution before trying to replicate environments and sync content

Eventual nice to haves:

• Error checking in case user has wrong credentials in .ini file and certs can't be copied over, etc...
• That sort of thing.

Right now rapidnode accepts content view as input. It makes more sense for rapidnode to accept an activation key. Change the input parameter from content view to activation key.

Installation using organization, environment and content view always leads to fail, as after registering the system, Capsule and Satellite tools repositories are disabled by default, causing yum -y install capsule-installer to fail.

• possible fix would be to add subscription-manager repos --enable rhel-6-server-satellite-*-6.1-rpms to the script in case the AK is not used

Presently, after installing/configuring a capsule, we go ahead and try to add environments and subsequently sync all capsules. While this doesn't/shouldn't cause any real harm (existing environments are rejected by validation), it could conceivably be problematic/slow if you had, say, 20 capsules already, each with 5 environments already.

Should probably just find a way to simply execute environment additions and syncs against capsules created this session.

It's probably easy storing the ID of each capsule, as you create it, and piping the env create/sync logic through that.

Capsule is will soon be installed differently, and thus rapidnode will need to be updated with these considerations in mind.

@elyezer's changes here provide some background.

SatelliteQE/automation-tools@master...elyezer:capsule-provisioning#diff-7797bab81dcdafa7d6dcf5ef179b3d65R255

Assuming everyone will use 'admin' is a poor assumption. We'll need to modify the code (and the sample ini) to support something other than 'admin'.

I: 23, 0: Locally disabling W0621 (locally-disabled)
I: 99, 0: Locally disabling C0301 (locally-disabled)
I:186, 0: Locally disabling W0632 (locally-disabled)
I:284, 0: Locally disabling R0914 (locally-disabled)