sasq64 / autotidy Goto Github PK

Current Bug behavior

AUR Arch Linux package of autotidy (aptly named autotidy-git) fails compilation.

Expected Behavior

AUR Arch Linux autotidy-git installs without compilation errors.

Steps to Reproduce

1. Upgrade current GCC to version 11
2. Attempt to install autotidy-git (manually or AUR helper) e.g. yay -S autotidy-git
3. Compilation will fail at abseil-cpp submodule.

Additional Information

Based upon my review of abseil-cpp submodule code base at commit d902eb8, file abseil-cpp/absl/synchronization/internal/graphcycles.cc implicitly includes <limits> resulting in compilation error at line 450.

This error only occurs for GCC versions 11 or newer, because of changes to header dependencies:

Some C++ Standard Library headers have been changed to no longer include other headers that they do need to depend on.
As such, C++ programs that used standard library components without including the right headers will no longer compile.

The following headers are used less widely in libstdc++ and may need to be included explicitly when compiled with GCC 11:

• (for std::numeric_limits)
• (for std::unique_ptr, std::shared_ptr etc.)
• (for std::pair, std::tuple_size, std::index_sequence etc.)
• (for members of namespace std::this_thread.)

Luckily, newer versions of abseil-cpp fix this issue, specifically at commit 5bf048b where <limits> is explicitly included. Thus, a possible fix is to update abseil-cpp submodule to a newer version and patch autotidy-git AUR.

For now, I will directly git clone autotidy and manually build it to see if any other issues arise.

I was wondering if there is a license for this project that I missed. If not, is there any chance you could add one? It's useful to have licenses available esp if people want to use a tool in a corporate shop.

From time to time, some commands are not listed in subsequent refactoring steps, e.g. [a]pply below

What is the reason? I couldn't figure out the pattern (not looked at the code yet, sorry).

I press 'a' or any other key and if the key is invalid (option not available), autotidy simply skips to next error....

That's not expected behavior, right?

This isn't a real issue, but I've created a package on the AUR, found here:
https://aur.archlinux.org/packages/autotidy-git/

If you want ownership of this package, I'm happy to hand it off to you. If not, I'm fine with maintaining it.