sarslanoglu / turkish_cities Goto Github PK

Listing cities should also include some basic data inside. These can be

• plate_number
• region
• phone_code
• metropolitan_municipality_since

Describe the bug
When processing the "sort alphabetically" method if the list has any record that contains a dot character, the program throws an exception.

To Reproduce
Steps to reproduce the behavior:

1. run rails c
2. run TurkishCities.list_neighborhoods('Artvin', 'Yusufeli')
3. program throws =>

ArgumentError: comparison of Array with Array failed
from /Users/username/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/turkish_cities-0.7.0/lib/turkish_cities/helpers/decomposer_helper.rb:80:in `sort_by'

Expected behavior
Users can see the neighborhoods of İzmir, Konak.
Example output:

[
...
"Abanoz Mah (Bahçeli Köyü)",
 "Abramet -kakrazevl Mah (Altıparmak Köyü)",
 "Ada Mah (Çevreli Köyü)",
 "Ada Mah (Irmakyanı Köyü)",
...
]

Is your feature request related to a problem? Please describe.
create_neighborhoods method is accepting 4 parameters and quite confusing for contributors.

Describe the solution you'd like
Refactoring to simpler method would be more beneficial.

#43

While reading YAML file in Rails apps, gem gives no file error like

errno::ENOENT: No such file or directory - bs_fetch:open_current_file:open

https://codeclimate.com/

distance_between_land method at Distance class is missing. It needs to be find land travel distances from here https://www.kgm.gov.tr/SiteCollectionDocuments/KGMdocuments/Root/Uzakliklar/ilmesafe.xls

Test suites got bigger and bigger. Refactor for smaller tests(maybe more tests with edge cases)

Dependabot can't resolve your Ruby dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Bundler::VersionConflict with message: Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 2.1.4)

  Current Bundler version:
    bundler (2.2.15)

Your bundle requires a different version of Bundler than the one you're running.
Install the necessary version with `gem install bundler:2.1.4` and rerun bundler using `run.rb _2.1.4_`

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Describe the bug
I installed the gem clearly as shown in documentation. After this step, I want to start my rails server. But I came across an error. I tried rails 5 and 7. Ruby 2.7.2.

To Reproduce
Steps to reproduce the behavior:

1. $ gem install turkish_cities
2. add gem 'turkish_cities' into the gem file
3. $ bundle
4. $ rails s

Expected behavior
Server should start.

Additional context

Describe the bug
This bug occurs with sending dummy or nested similar parameters to list_neighborhoods method.
To briefly explain, If a district is not exist gem can not open yaml file and throw an error like

Caught the exception: No such file or directory @ rb_sysopen - /Users/atagunay/.asdf/installs/ruby/3.2.1/lib/ruby/gems/3.2.0/gems/turkish_cities 0.7.0/lib/turkish_cities/helpers/../data/districts/xxxx.yaml

Under normal conditions, this error can handle via district_item method. Because it return nil.
But if a person send nested parameters like:

city: xxx
district: xx

district_item can not return nil with these parameters. Because it find "xx" in "xxx". And then code broken.

To Reproduce
Steps to reproduce the behavior:

1. TurkishCities.list_neighborhoods('xxx','xx')

Expected behavior
As a user, I should see meaningful error message like "Couldn't find district name with 'xxx' of 'xx'"

Describe the bug
When processing the "sort alphabetically" method if the list has any record that contains a dot character, the program throws an exception.

To Reproduce
Steps to reproduce the behavior:

1. run rails c
2. run TurkishCities.list_neighborhoods("İzmir", "Konak")
3. program throws =>

ArgumentError: comparison of Array with Array failed
from /Users/username/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/turkish_cities-0.7.0/lib/turkish_cities/helpers/decomposer_helper.rb:80:in `sort_by'

Expected behavior
Users can see the neighborhoods of İzmir, Konak.
Example output:

[
  "1.kadriye Mah",
  "19 Mayıs Mah",
  "2.kadriye Mah",
  "26 Ağustos Mah"
]

Dependabot can't resolve your Ruby dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Bundler::VersionConflict with message: Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 2.2.16)

  Current Bundler version:
    bundler (2.2.15)

Your bundle requires a different version of Bundler than the one you're running.
Install the necessary version with `gem install bundler:2.2.16` and rerun bundler using `run.rb _2.2.16_`

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

For example 34380 should return 'Istanbul/Sisli/Cumhuriyet'

TurkishCities.find_plate_number_by_name('Istanbul') # => nil

it should return

TurkishCities.find_plate_number_by_name('Istanbul') # => 34
TurkishCities.find_plate_number_by_name('Izmir') # => 35
TurkishCities.find_plate_number_by_name('Isparta') # => 32

Describe the bug
When I run TurkishCities.list_neighborhoods('Eskişehir', 'Odunpazarı', 'Büyükkkkkdere') it gives me NoMethodError (undefined method `[]' for nil:NilClass)

To Reproduce
Steps to reproduce the behavior:

1. In terminal require 'turkish_cities'
2. Call TurkishCities.list_neighborhoods('Eskişehir', 'Odunpazarı', 'Büyükkkkkdere')

Expected behavior
It should return more meaningful error messages to user like "Couldn't find subdistrict name with 'Büyükkkkkdere' of 'Odunpazarı/Eskişehir'"

Is your feature request related to a problem? Please describe.
Some subdistrict became district. And some subdistrict merged with larger ones

Describe the solution you'd like
Up to date list of districts

Describe alternatives you've considered

Additional context

distance_between_sea method is missing at Distance class. Sea travel distance and time estimation can be found here
http://ytb.org.tr/tr/faydali_bilgiler/index/17

Next phase is listing sub_districts of districts. These subdistricts can be found in yaml files under ./data/districts

Is your feature request related to a problem? Please describe.
Some of the methods were overlooked in district class while fixing #45 .

Describe the solution you'd like
Improve the code for these methods and similar ones.

Is your feature request related to a problem? Please describe.

Unforeseen characters may appear while sorting. For this reason, a control mechanism should be developed for these characters.

Describe the solution you'd like

If the character is not in the predefined character set, skip to the last in the sequence.

Describe the bug
In 0.6.1 version, if gem can not find anything, it return this string "translation missing: tr.errors.city_not_found_error". But it should something like that "Couldn't find city name with 'İstan'".

To Reproduce

1. districts = TurkishCities.list_districts('istanb')
2. "translation missing: tr.errors.city_not_found_error".

Expected behavior

1. districts = TurkishCities.list_districts('istanb')
2. "Couldn't find city name with 'İstan'"

Additional context
I try to use 0.3.0. There are not a problem. But 0.6.1 has this bug.

https://coveralls.io

New way to support both turkish and english texts inside gem