Giter Club home page Giter Club logo

Comments (3)

dominikschreiber avatar dominikschreiber commented on July 27, 2024 1

Thank you for your quick feedback! After more consideration, SAP Design now has the impression that sapFontHeaderFamily should not be bold in Horizon HCB as well. They updated the Theming – Typography (Horizon) specification to reflect that. I'll also show them the link you provided and ask to keep both in sync.

from theming-base-content.

dominikschreiber avatar dominikschreiber commented on July 27, 2024

Hi @VictorHumanist, you have the eyes of an eagle!

I had a quick chat with colleagues from SAP Design. Having @sapFontHeaderFamily mapped to @sapFontFamily in Horizon HCW and to @sapFontBoldFamily everywhere else is intentional. Hence, I'll close this issue.

Nevertheless, I'd be interested if this outlier causes issues for you. Can you share your use-case?

from theming-base-content.

VictorHumanist avatar VictorHumanist commented on July 27, 2024

I just noticed that the form headers are not bold in HCW, while bold in others, including HCB:

image_2024-06-10_141300698

image_2024-06-10_142000289

Quick investigation showed the reason, and I naturally thought it was a mistake.
Header spec was taken from https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698913674

Guess I should just add font-weight: bold.

from theming-base-content.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.