Comments (4)
Solved with version 11.1.13
css_variables.css
from theming-base-content.
The files are not human-readable but still parse-able as they work in the browsers.
The variable-files should be presented in a way that they can be read by humans to get a better overview of the existing variables. We need to think about that. Maybe we just switch off the “compression”.
If you want to parse the files you cannot rely on the whitespace structure. This will change eventually. A simple string separation by e.g. RegExp is not sufficient. You need to parse it in a reliable way according to the file type.
from theming-base-content.
For me to consume your CSS/LESS/SASS var values in my local CSS/LESS/SASS, I need to be able to easily read them.
When I am ready to publish what ever component or app I have, I will be webpacking/minifying/treeshaking, etc that code. There is no need for you to deliver them minified
Delivering them minified like this also has the added detriment of making it almost impossible to track changes over time, as the diffs will almost always occur the the same line number.
from theming-base-content.
The “less” files over the theme hierarchy are the source for the CSS/LESS/SASS build output files. You can track those non-minified files for changes.
The repo files are intended to be used directly … not as a parsed source for another build input (not sure why you need to parse it). Therefore, a minified output makes sense from my point of view.
Anyway, I see the still the point of the readability of the variable files for humans. Especially in the current introduction phase of the parameters. So I agree that the minification should be disabled for those variable files. I discuss it in the team and ask for an item in our backlog.
The problem is that the files in the repo are a part of the SAP Base content build which is completely minified. Unfortunately, the minification is done while the file creation and is not a post build step. It can only be turned on/off for all files ... for all official deliveries.
We need some code which excludes the variable files from minification.
from theming-base-content.
Related Issues (15)
- bug(horizon): radio button border-style resolved to none HOT 1
- The issue about upgrading the version from 11.1.34 to 11.1.40 HOT 1
- bug: loading placeholders wrong colors HOT 1
- bug: emphasized button color in evening horizon
- bug: emphasized button color in evening horizon HOT 1
- Corrupt 11.1.48 tarball HOT 1
- Icons not centered vertically HOT 4
- Horizon focus color HOT 1
- CSS variable files should differentiate between variables and variables that load assets HOT 8
- Feedback icon is missing in 'SAP-icons' font HOT 1
- Missing 72-Italic.woff2 HOT 2
- Why there is no SAP Belize Deep in theming-base-content, Only SAP Belize Plus? HOT 4
- Can I delete some Unnecessary font-face declaration in content/Base/baseLib/sap_belize_plus/css_variables.css HOT 3
- Invalid css in css_variables.css HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theming-base-content.