sap-archive / spring-cloud-sap Goto Github PK

It would be nice to see a readme of sorts that explains how to

• deploy this to CF
• set it up as a service
• install any required drivers

When trying to establish a Hana DB connection in our CF landscape using spring-cloud-cloudfoundry-hana-service-connector we are getting an exception from the Hana driver:
2018-09-14T13:11:07.52-0700 [APP/PROC/WEB/0] ERR com.sap.db.jdbc.exceptions.JDBCDriverException: SAP DBTech JDBC: [4321]: only secure connections are allowed 2018-09-14T13:11:07.52-0700 [APP/PROC/WEB/0] ERR at com.sap.db.jdbc.exceptions.SQLExceptionSapDB.createException(SQLExceptionSapDB.java:345) 2018-09-14T13:11:07.52-0700 [APP/PROC/WEB/0] ERR at com.sap.db.jdbc.exceptions.SQLExceptionSapDB.generateDatabaseException(SQLExceptionSapDB.java:185) 2018-09-14T13:11:07.52-0700 [APP/PROC/WEB/0] ERR at com.sap.db.jdbc.packet.ReplyPacket.buildExceptionChain(ReplyPacket.java:102) 2018-09-14T13:11:07.52-0700 [APP/PROC/WEB/0] ERR at com.sap.db.jdbc.ConnectionSapDB.execute(ConnectionSapDB.java:1033)

From looking into HANAServiceInfoCreator -> createServiceInfo() it seems that the URL created for the connectivity doesn't contain options for:

1. encrypt
2. validateCertificate

As a result the connectivity to our Hana instance is failing (see stack trace).
It seems we need some configuration options for HANAServiceInfoCreator to allow for better URL composition.

Hi Matthias,

I came across with your spring-cloud-cloudfoundry-hana-service-connector which sounds like it could help me with my project. I have an HCP Cloud Foundry python application which I want to connect to the HCP Hana instance. Will spring-cloud-cloudfoundry-hana-service-connector expose the hana instance connection details to a cloud foundry app? How would I use that with a non-spring applications?

If this is not the right place for the question, pls. feel free to move it where you find it more appropriate.

Many thanks
Kruno

We found today that the datasource creation here fails for the SAP Hana Service with the normal hana service binding in our SAP Cloud Platform (it did work for our old PSA Hana).

We took a trace of the working and not working case and found that in the working case, where we manually copied the values from the service binding we had

# working (manual copy from env)
url=jdbc:sap://zeus.hana.prod.us-east-1.whitney.dbaas.ondemand.com:20142?encrypt=true&validateCertificate=true&currentschema=XXX;
# not working (via cloud-connector)
url=jdbc:sap://zeus.hana.prod.us-east-1.whitney.dbaas.ondemand.com:20142/null?user=XXX&password=XXX;

Note the /null in the second case, which looks suspiciously like
https://github.com/SAP/spring-cloud-sap/blob/master/spring-cloud-cloudfoundry-hana-service-connector/src/main/java/com/sap/hana/cloud/hcp/cf/HANAServiceInfoCreator.java#L50

Of course this is also related to #8, where I agree with the author that security parameters should not be taken from the URI.

When HANAServiceInfo object is created in HANAServiceInfoCreator, query part of the URL is not used.
It should ideally append the query part of the URL to the JDBC query string .

Due to this, library may fail to connect to HANA Service in CF. (like ?encrypt=true mandatory parameter)