santip / maximize-panes Goto Github PK

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.1.0) of this package:

1. Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
2. Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
3. atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.

If this package has been replaced by another package or functionality in core, please reply with this information.

See atom/atom#6867 for more info. Thanks!

Currently, there's no visual cue. Someone could forget that they maximized a pane, then they might try and make a new split or something, and possibly mess up the state (not sure if all possible cases have been tested, but a visual clue would remind the user to un-maximize before continuing with an action).

I think that's a lot of time resource spent there.

I'm wondering what could be improved in order to reduce that time.

In stylesheets/maximize-panes.less: Use the atom-pane tag instead of the pane class.

In keymaps/maximize-panes.cson: Use the atom-text-editor tag instead of the editor class.

Doesn't seem to work on

Atom    : 1.29.0
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3

Like in other IDEs :)
Would be awesome

This is a very handy plugin, thank you for making this. Here's an issue I ran into using v0.2.0.

Actual Behavior: If you split the layout into a Left Pane and a Right Pane, and then split the Right pane into Top and Bottom (see screenshot), maximizing either the Top Right Pane or Bottom Right Pane will not take up the entire window area; it will instead take up only the entire Right area, leaving the Left Pane still on the screen.

Expected Behavior: Maximizing any of the three panes results in the pane taking up the entire screen area.

In stylesheets/maximize-panes.less: Use the atom-pane-container tag instead of the panes class.

I tried to get this working, but the shortcut didn't work. I kept pressing CMD+Shift+Enter but nothing happened. The package sounds like something that would be very useful to me. In the end I just ended up changing the Preferred Line Length to something much larger. I was using Atom v0.91.

So let's say I have my window separated vertically right down the middle, and separated horizontally only on the left side (I had text tables here but github's formatting ruined it :( ). I can maximize the right side (the side that's not separated horizontally) all the way, but the left side's panes only maximize vertically (the right side doesn't go away).

Is this a feature or a bug? I see that the example has this setup too but doesn't have this behavior.

Deetz:
Atom version: 1.3.1
OS: Fedora 23 Linux 4.2.6-301.fc23.x86_64

In keymaps/maximize-panes.cson: Use the atom-workspace tag instead of the workspace class.

According to Atom's Deprecation Cop, Package.getActivationCommands is deprecated and will be removed when Atom 1.0 is released in June. Recommended action:

Use activationCommands instead of activationEvents in your package.json.

Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:808:9)
Package.hasActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:733:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:185:24)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)
PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:355:14)

According to Atom's Deprecation Cop, Package.getStylesheetsPath is deprecated and will be removed when Atom 1.0 is released in June. Recommended action:

Store package style sheets in the styles/ directory instead of stylesheets/.

Package.getStylesheetsPath (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:460:9)
Package.getStylesheetPaths (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:471:32)
Package.loadStylesheets (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:453:38)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:19)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)

Suggested new keybinding: alt-cmd-enter

When I maximize a pane, I expect that all the atom interface be cleaned so I can focus only in my coding. Instead, when I maximize pane the tree view is still there.
It's me or you also feel like that tree view should be hidden when maximizing pane?