sandrock / sekvap-dotnet Goto Github PK

As SekvapLanguage does not maintain a state related to the data it processes, we can create a singleton instance. This would avoid declaring/creating too many instances in our apps.

These two static instances would help a lot:

SekvapLanguage.Default = new SekvapLanguage();
SekvapLanguage.TrimAllWhispaces = new SekvapLanguage()
{
    TrimKeyStart = true, TrimKeyEnd = true,
    TrimValueStart = true, TrimValueEnd = true,
};

Consider the following data strings:

Key1=Value...1;Key2=Valu  ;Key3=X
Key1=Value1;   Key2=Value2;Key3=X

The user may use whitespaces to align keys and values. Consider adding three 4 properties to the parser in order to trim these characters.

bool TrimKeyLeft
bool TrimKeyRight
bool TrimValueLeft
bool TrimValueRight

These unit tests are bugged:

• SerializeEnumerableMethod.SerializeEnumerableMethod
• SerializeEnumerableMethod.Value_Item
• SerializeEnumerableMethod.Value_Item_Value

And the implementation is wrong.

This assert type: Assert.Equal("Hello;Foo=Bar;Value=Yop", result); fails.
We get "Value=Hello;Foo=Bar;Value=Yop"

Current build targets Profile344 (portable-net45+sl5+win8+wpa81+wp8).

Microsoft indicates:

PCLs are not recommended. Although PCLs are supported, package authors should support netstandard instead. The .NET Platform Standard is an evolution of PCLs and represents binary portability across platforms using a single moniker that isn't tied to a static library like portable-a+b+c monikers.

Support for Silverlight and Windows Phone may be dropped. A net40 + netstandard2.0 seems fine.