Giter Club home page Giter Club logo

marvel-comics-app's Introduction

Build Status codecov

Marvel Comics

A simple Android app that provides easy access to a list of available comics hosted by Marvel, and detailed information about each one of them.

Features

With the app, you can:

  • Discover the latest Marvel comics
  • Read details (Date Published, Price, Page Count and Creators)

Getting Started

This sample uses the Gradle build system. To build this project, use the "gradlew build" command or use "Import Project" in Android Studio.

How to Work with the Source

This app uses Marvel API to retrieve comics. You must provide your own Public API key in order to build the app. When you get it, just paste it to: secrets.properties

Tests

Android tests are located under src/androidTest/java

See the test suite MarvelComics/app/src/androidTest/java/com/hulldiscover/zeus/marvelcomics/FullTestSuite.java to run all test at once.

Libraries used in this project

Notes

How solution could be improved:

  • Implement Spinners - to provide a quick way to select "order by/sort by" options from a set [title, issue number, etc].
  • Include Shared Preferences/ Settings - with the ability toggle the inclusion comic collections or series.
  • Implement Pull To Refresh - to update list of comics.
  • Add Favorites feature - to provide to ability for users to save their favourite comics.
  • Implement some UI Test using Mokito and JUnit.
  • Given a budget, the app should be able to find and list the maximum number of comics that you can buy without exceeding that budget from the 100 comics listed previously. Also all the comics combined should give you the maximum number of pages you can read.
  • Share button - to share comic details with friends.

What I would do better:

Features that need fixes :

  • Continuos Integration script currently isnt succesfully building. I need to change the build parameters.
  • Code Coverage isn't building. I need to fix the lingage between the app and the code coverage online tool.
  • Offline. Currently comic data is stored in SQLite database, and Sync features have been implemented to allow offline viewing. However, this don't not fully function as intended. I will need to investigate what the app does when not internet connectivity is detected.
  • Description text in detailed view of comic. The data pulled from the API needs to be formatted for display.
  • Poster Image. This image is stretched out, and looks pixalated. I will need to change the aspect ratio.

License

Copyright 2016 Andre Hitchman

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

marvel-comics-app's People

Contributors

sandboxdeveloper avatar

Watchers

James Cloos avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.