Should component scope inside a collection preserve parent selector? about ember-cli-page-object HOT 6 CLOSED

Hi @leonardocsouza, this is an issue indeed!

We detected this issue some days ago but I forgot to open an issue to let everyone else to be aware of it, thanks for reporting the issue.

We're working on a fix for it, see #62 specially the commit b09dd00

For now, another workaround is to wrap the component in a customHelper, for example

let flaggingMenu = customHelper(function(selector) {
  return {
    scope: `${selector} .flagging-menu`,
    isOpen: hasClass('is-open'),

    selectCurrent: clickable('.mark.current'),
    selectPast: clickable('.mark.past'),
    selectUrgent: clickable('.mark.urgent')
  };
});

let topics = collection({
  itemScope: '.topic',
  item: {
    title: text('.title'),
    flaggingMenu
  }
});

Please, let me know if this works for you.

from ember-cli-page-object.

Thank you SO much for the quick and detailed reply!

I thought a customHelper could be a good solution, but had not tried that yet. I've just tested it now with the info you shared above and it seems like I may be missing some step to get it to work because it just comes back as a plain javascript Object as if it didn't get initialized or something like that.

In any case, we have a workaround that solves the problem for now, and I have it wrapped in a test helper so that whenever the fix for this is released I can just replace it in one place.

Thank you again!

Best,
Leo

from ember-cli-page-object.

Yes, you are right, let me fix the example so others can use it.

let menu = customHelper(function(selector) {
  return {
    scope: selector,
    isOpen: hasClass('is-open'),

    selectCurrent: clickable('.mark.current'),
    selectPast: clickable('.mark.past'),
    selectUrgent: clickable('.mark.urgent')
  };
});

let topics = collection({
  itemScope: '.topic',
  item: {
    title: text('.title'),
    flaggingMenu: menu('.flagging-menu')
  }
});

customHelper always returns a function, and the selector you pass to it will be scoped to the item level.

Although this is just a workaround for the issue you posted, it's a nice example of the power of the customHelper.

Cheers

from ember-cli-page-object.

Fixed by #62

from ember-cli-page-object.

@leonardocsouza the fix is included on version 0.8.1. Thanks again for your report!

https://github.com/san650/ember-cli-page-object/releases/tag/v0.8.1

from ember-cli-page-object.

Awesome! Thank you for the update and for the fix! :) 👍

from ember-cli-page-object.