Giter Club home page Giter Club logo

Comments (4)

cah-brian-gantzler avatar cah-brian-gantzler commented on June 5, 2024

Ok I see that this assign is imported in many other files. Could this line be replaced with?

export { Object.assign as assign };

from ember-cli-page-object.

cah-brian-gantzler avatar cah-brian-gantzler commented on June 5, 2024

Appears this is fixed in PR https://github.com/san650/ember-cli-page-object/pull/536/files but this was merged into the V2-beta branch

Since this branch hasnt been touched since Jan 30, any way we could maybe backport this fix so consumers can upgrade to Ember 4 without waiting on the V2 version of this addon?

from ember-cli-page-object.

ro0gr avatar ro0gr commented on June 5, 2024

Sorry for delay.

Yes, I'd prefer to use the object spread approach as you referred above. Unfortunately, I doubt if it can be just cherry-picked, cause of many changes in beta happened and conflicts are possible. I think we still can do it manually though, w/o a big issue.

from ember-cli-page-object.

ro0gr avatar ro0gr commented on June 5, 2024

Just released the fix as a part of https://github.com/san650/ember-cli-page-object/releases/tag/v1.17.12

from ember-cli-page-object.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.