samvera-deprecated / sufia Goto Github PK

View Code? Open in Web Editor NEW

111.0 52.0 78.0 58.3 MB

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.

Home Page: http://sufia.io/

License: Other

Ruby 66.37% JavaScript 12.41% HTML 16.58% CSS 2.25% CoffeeScript 0.70% XSLT 1.70%

sufia's People

Contributors

Stargazers

Watchers

sufia's Issues

"ScholarSphere" branding

There's some scholarsphere branding in the header.. probably should be replaced with Sufia or nothing?

<div id="masthead">
    <a class="brand shield" href="/">ScholarSphere</a>

link_to_facet calls are still using hardcoded field names

Should characterize be kicked off by Sufia::GenericFile::Actions.create_content?

Then we can remove the around_save :characterize_if_changed from GenericFile.

This makes the code easier to follow.

jQuery.live() is removed as of jQuery 1.9

.live() has been deprecated, in favor of .on() or .delegate()

Need to update the javascript.

Some problems with searching functions

Hi,

I've set up the sufia on my local computer but the search function cannot work well. After depositing files searching engine cannot find it. The solr is working well, I think, because the admin page is available. Anybody has the same problem?

Any documents for developing? Such as define my own model, change fields for solr's search.

I just have the doc for sufia installation, that's a great doc.
But I can't find any doc for developing. My demand list below:

define more metadata for model,such as "publisher, price" for Book.
No matter which type I choose, book or article, the matadata is all the same. Can I change it?
blacklight only can search title field. How can I define more field for searching?

Is there any docments for those demand?

Thanks!

Latest download controller update stopped pdf thumbnails from being displayed

https://github.com/projecthydra/sufia/blob/master/app/views/generic_files/_media_display.html.erb#L32

There is not update here for type which causes this error:
ArgumentError (:type option required):
actionpack (3.2.13) lib/action_controller/metal/data_streaming.rb:141:in block in send_file_headers!' actionpack (3.2.13) lib/action_controller/metal/data_streaming.rb:140:ineach'
actionpack (3.2.13) lib/action_controller/metal/data_streaming.rb:140:in send_file_headers!' hydra-core (6.1.1) lib/hydra/controller/download_behavior.rb:69:insend_content'
hydra-core (6.1.1) lib/hydra/controller/download_behavior.rb:15:in show' actionpack (3.2.13) lib/action_controller/metal/implicit_render.rb:4:insend_action'
actionpack (3.2.13) lib/abstract_controller/base.rb:167:in process_action' actionpack (3.2.13) lib/action_controller/metal/rendering.rb:10:inprocess_action'
actionpack (3.2.13) lib/abstract_controller/callbacks.rb:18:in block in process_action' activesupport (3.2.13) lib/active_support/callbacks.rb:502:in_run__729985115566013699__process_action__2710621655081788020__callbacks'
activesupport (3.2.13) lib/active_support/callbacks.rb:405:in __run_callback' activesupport (3.2.13) lib/active_support/callbacks.rb:385:in_run_process_action_callbacks'
activesupport (3.2.13) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.2.13) lib/abstract_controller/callbacks.rb:17:inprocess_action'
actionpack (3.2.13) lib/action_controller/metal/rescue.rb:29:in process_action' actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:30:inblock in process_action'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in block in instrument' activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:ininstrument'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in instrument' actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:29:inprocess_action'
actionpack (3.2.13) lib/action_controller/metal/params_wrapper.rb:207:in process_action' activerecord (3.2.13) lib/active_record/railties/controller_runtime.rb:18:inprocess_action'
actionpack (3.2.13) lib/abstract_controller/base.rb:121:in process' actionpack (3.2.13) lib/abstract_controller/rendering.rb:45:inprocess'
actionpack (3.2.13) lib/action_controller/metal.rb:203:in dispatch' actionpack (3.2.13) lib/action_controller/metal/rack_delegation.rb:14:indispatch'
actionpack (3.2.13) lib/action_controller/metal.rb:246:in block in action' actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:73:incall'
actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:73:in dispatch' actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:36:incall'
journey (1.0.4) lib/journey/router.rb:68:in block in call' journey (1.0.4) lib/journey/router.rb:56:ineach'
journey (1.0.4) lib/journey/router.rb:56:in call' actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:612:incall'
railties (3.2.13) lib/rails/engine.rb:479:in call' railties (3.2.13) lib/rails/railtie/configurable.rb:30:inmethod_missing'
journey (1.0.4) lib/journey/router.rb:68:in block in call' journey (1.0.4) lib/journey/router.rb:56:ineach'
journey (1.0.4) lib/journey/router.rb:56:in call' actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:612:incall'
warden (1.2.1) lib/warden/manager.rb:35:in block in call' warden (1.2.1) lib/warden/manager.rb:34:incatch'
warden (1.2.1) lib/warden/manager.rb:34:in call' actionpack (3.2.13) lib/action_dispatch/middleware/best_standards_support.rb:17:incall'
rack (1.4.5) lib/rack/etag.rb:23:in call' rack (1.4.5) lib/rack/conditionalget.rb:25:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/head.rb:14:in call' actionpack (3.2.13) lib/action_dispatch/middleware/params_parser.rb:21:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/flash.rb:242:in call' rack (1.4.5) lib/rack/session/abstract/id.rb:210:incontext'
rack (1.4.5) lib/rack/session/abstract/id.rb:205:in call' actionpack (3.2.13) lib/action_dispatch/middleware/cookies.rb:341:incall'
activerecord (3.2.13) lib/active_record/query_cache.rb:64:in call' activerecord (3.2.13) lib/active_record/connection_adapters/abstract/connection_pool.rb:479:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/callbacks.rb:28:in block in call' activesupport (3.2.13) lib/active_support/callbacks.rb:405:in_run__2801231739801228177__call__467636624230541221__callbacks'
activesupport (3.2.13) lib/active_support/callbacks.rb:405:in __run_callback' activesupport (3.2.13) lib/active_support/callbacks.rb:385:in_run_call_callbacks'
activesupport (3.2.13) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.2.13) lib/action_dispatch/middleware/callbacks.rb:27:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/reloader.rb:65:in call' actionpack (3.2.13) lib/action_dispatch/middleware/remote_ip.rb:31:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/debug_exceptions.rb:16:in call' actionpack (3.2.13) lib/action_dispatch/middleware/show_exceptions.rb:56:incall'
railties (3.2.13) lib/rails/rack/logger.rb:32:in call_app' railties (3.2.13) lib/rails/rack/logger.rb:16:inblock in call'
activesupport (3.2.13) lib/active_support/tagged_logging.rb:22:in tagged' railties (3.2.13) lib/rails/rack/logger.rb:16:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/request_id.rb:22:in call' rack (1.4.5) lib/rack/methodoverride.rb:21:incall'
rack (1.4.5) lib/rack/runtime.rb:17:in call' activesupport (3.2.13) lib/active_support/cache/strategy/local_cache.rb:72:incall'
rack (1.4.5) lib/rack/lock.rb:15:in call' actionpack (3.2.13) lib/action_dispatch/middleware/static.rb:63:incall'
railties (3.2.13) lib/rails/engine.rb:479:in call' railties (3.2.13) lib/rails/application.rb:223:incall'
rack (1.4.5) lib/rack/content_length.rb:14:in call' railties (3.2.13) lib/rails/rack/log_tailer.rb:17:incall'
unicorn (4.6.2) lib/unicorn/http_server.rb:552:in process_client' unicorn (4.6.2) lib/unicorn/http_server.rb:632:inworker_loop'
unicorn (4.6.2) lib/unicorn/http_server.rb:500:in spawn_missing_workers' unicorn (4.6.2) lib/unicorn/http_server.rb:142:instart'
unicorn-rails (1.0.1) lib/unicorn/rails.rb:20:in run' rack (1.4.5) lib/rack/server.rb:268:instart'
railties (3.2.13) lib/rails/commands/server.rb:70:in start' railties (3.2.13) lib/rails/commands.rb:55:inblock in <top (required)>'
railties (3.2.13) lib/rails/commands.rb:50:in tap' railties (3.2.13) lib/rails/commands.rb:50:in<top (required)>'
script/rails:6:in require' script/rails:6:in

Properly lock the noid minter

you should do something like this when calling NOID:
https://github.com/microservices/noid/blob/master/spec/lib/minter_spec.rb#L182

Possibly Add ImageMagick to "Sufia needs the following software to work" section in README

Sufia depends on SufiaModles which depends on HydraDerivatives which requires RMagick. You can't install the RMagick gem without ImageMagick installed on the system.

Possibly consider adding ImageMagick into the list of software required for Sufia to work.

Can we remove anchor tags without href?

The anchor tags in the message don't seem valid without href or name. Are they useful for anything?

lib/sufia/controller.rb:52:      @batches=current_user.mailbox.inbox.map {|msg| msg.last_message.body[/<a class="batchid ui-helper-hidden">(.*)<\/a>The file(.*)/,1]}.select{|val| !val.blank?}
lib/sufia/jobs/batch_update_job.rb:48:    message = '<a class="batchid ui-helper-hidden">ss-'+batch.noid+'</a>The file(s) '+ file_list(@saved)+ " have been saved." unless @saved.empty?

'Invalid date' when editing a generic file

Port the AccessRight and WithAccessRight from Curate

I worked on extracting this logic so that the views weren't so cumbersome with lots of painful logic.

https://github.com/ndlib/curate/blob/master/app/repository_models/curation_concern/with_access_right.rb

https://github.com/ndlib/curate/blob/master/app/models/access_right.rb

Test occasionally fails. Bad test?

Sufia::IdService mint should create many unique ids
Failure/Error: a.uniq.count.should == a.count
expected: 1000
got: 999 (using ==)
./spec/lib/sufia/id_service_spec.rb

Dashboard javascript doesn't work with jquery-rails ~> 2.2.0 (jquery 1.9)

See samvera-deprecated/hydra-batch-edit#3

In ChecksumAuditLog change column `pass` from int to boolean, remove expected/received

Uploading file errors out on displaying metadata form

Web application based on sufia. Create account and log in. Go to Upload page, click deposit agreement box, select file, and start upload. File uploads okay but then get "invalid date" error.

Loaded datastream profile sufia:z029p481w/RELS-EXT (7.7ms)
Loaded datastream list for sufia:z029p4825 (3.9ms)
Loaded datastream profile sufia:z029p4825/RELS-EXT (6.2ms)
Loaded datastream content sufia:z029p4825/RELS-EXT (4.4ms)
Loaded datastream profile sufia:z029p4825/content (3.0ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_rights_modal.html.erb (0.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.5ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (4.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (14.4ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_resource_type.html.erb (1.0ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (4.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (7.7ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (10.5ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (14.3ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.5ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (5.4ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (15.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.4ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (11.7ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (15.9ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.5ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_description.html.erb (4.8ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (6.7ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (1.3ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (8.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_rights_modal.html.erb (0.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (2.0ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_rights.html.erb (11.0ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (12.0ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (4.9ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (15.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_suffix.html.erb (0.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/edit_fields/_default.html.erb (14.4ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (18.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/generic_files/_field_form.html.erb (1.5ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/batch/_more_metadata.html.erb (142.6ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/batch/_metadata.html.erb (159.8ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-2.0.1/app/views/batch/edit.html.erb within layouts/sufia-one-column (163.2ms)
Completed 500 Internal Server Error in 631ms

ActionView::Template::Error (invalid date):
8: <%= f.label key, get_label(key), :class=>"control-label"%>
9: <% end %>
10:
11: <% vals.to_ary.each_with_index do |v, index| %>
12: <%= render_edit_field_partial(key, record: generic_file, f:f, v: v, index: index, render_req: render_req) %>
13: <% end %>
14:
active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:65:in parse' active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:65:inblock in load_values'
active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:61:in each' active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:61:inload_values'
active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:55:in target' active-fedora (6.4.3) lib/active_fedora/rdf_node/term_proxy.rb:6:into_ary'
sufia (2.0.1) app/views/generic_files/_field_form.html.erb:11:in __home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_generic_files__field_form_html_erb__447219148__625379638' actionpack (3.2.13) lib/action_view/template.rb:145:inblock in render'
activesupport (3.2.13) lib/active_support/notifications.rb:125:in instrument' actionpack (3.2.13) lib/action_view/template.rb:143:inrender'
actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:265:in render_partial' actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:238:inblock in render'
actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:in block in instrument' activesupport (3.2.13) lib/active_support/notifications.rb:123:inblock in instrument'
activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:in instrument' activesupport (3.2.13) lib/active_support/notifications.rb:123:ininstrument'
actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:in instrument' actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:237:inrender'
actionpack (3.2.13) lib/action_view/renderer/renderer.rb:41:in render_partial' actionpack (3.2.13) lib/action_view/renderer/renderer.rb:15:inrender'
actionpack (3.2.13) lib/action_view/helpers/rendering_helper.rb:24:in render' sufia (2.0.1) app/views/batch/_more_metadata.html.erb:3:inblock in __home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_batch__more_metadata_html_erb___444465848__627578468'
sufia (2.0.1) app/views/batch/_more_metadata.html.erb:2:in each' sufia (2.0.1) app/views/batch/_more_metadata.html.erb:2:in__home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_batch__more_metadata_html_erb___444465848__627578468'
actionpack (3.2.13) lib/action_view/template.rb:145:in block in render' activesupport (3.2.13) lib/active_support/notifications.rb:125:ininstrument'
actionpack (3.2.13) lib/action_view/template.rb:143:in render' actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:265:inrender_partial'
actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:238:in block in render' actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:inblock in instrument'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in block in instrument' activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:ininstrument'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in instrument' actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:ininstrument'
actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:237:in render' actionpack (3.2.13) lib/action_view/renderer/renderer.rb:41:inrender_partial'
actionpack (3.2.13) lib/action_view/renderer/renderer.rb:15:in render' actionpack (3.2.13) lib/action_view/helpers/rendering_helper.rb:24:inrender'
sufia (2.0.1) app/views/batch/_metadata.html.erb:79:in __home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_batch__metadata_html_erb___640832457_95050950' actionpack (3.2.13) lib/action_view/template.rb:145:inblock in render'
activesupport (3.2.13) lib/active_support/notifications.rb:125:in instrument' actionpack (3.2.13) lib/action_view/template.rb:143:inrender'
actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:265:in render_partial' actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:238:inblock in render'
actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:in block in instrument' activesupport (3.2.13) lib/active_support/notifications.rb:123:inblock in instrument'
activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:in instrument' activesupport (3.2.13) lib/active_support/notifications.rb:123:ininstrument'
actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:in instrument' actionpack (3.2.13) lib/action_view/renderer/partial_renderer.rb:237:inrender'
actionpack (3.2.13) lib/action_view/renderer/renderer.rb:41:in render_partial' actionpack (3.2.13) lib/action_view/renderer/renderer.rb:15:inrender'
actionpack (3.2.13) lib/action_view/helpers/rendering_helper.rb:24:in render' sufia (2.0.1) app/views/batch/edit.html.erb:48:inblock in __home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_batch_edit_html_erb___974871489_89886070'
actionpack (3.2.13) lib/action_view/helpers/capture_helper.rb:40:in block in capture' actionpack (3.2.13) lib/action_view/helpers/capture_helper.rb:187:inwith_output_buffer'
actionpack (3.2.13) lib/action_view/helpers/capture_helper.rb:40:in capture' actionpack (3.2.13) lib/action_view/helpers/form_helper.rb:378:inform_for'
sufia (2.0.1) app/views/batch/edit.html.erb:46:in __home_coblej__rvm_gems_ruby_______p____sufia_gems_sufia_______app_views_batch_edit_html_erb___974871489_89886070' actionpack (3.2.13) lib/action_view/template.rb:145:inblock in render'
activesupport (3.2.13) lib/active_support/notifications.rb:125:in instrument' actionpack (3.2.13) lib/action_view/template.rb:143:inrender'
actionpack (3.2.13) lib/action_view/renderer/template_renderer.rb:47:in block (2 levels) in render_template' actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:inblock in instrument'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in block in instrument' activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:ininstrument'
activesupport (3.2.13) lib/active_support/notifications.rb:123:in instrument' actionpack (3.2.13) lib/action_view/renderer/abstract_renderer.rb:38:ininstrument'
actionpack (3.2.13) lib/action_view/renderer/template_renderer.rb:46:in block in render_template' actionpack (3.2.13) lib/action_view/renderer/template_renderer.rb:54:inrender_with_layout'
actionpack (3.2.13) lib/action_view/renderer/template_renderer.rb:45:in render_template' actionpack (3.2.13) lib/action_view/renderer/template_renderer.rb:18:inrender'
actionpack (3.2.13) lib/action_view/renderer/renderer.rb:36:in render_template' actionpack (3.2.13) lib/action_view/renderer/renderer.rb:17:inrender'
actionpack (3.2.13) lib/abstract_controller/rendering.rb:110:in _render_template' actionpack (3.2.13) lib/action_controller/metal/streaming.rb:225:in_render_template'
actionpack (3.2.13) lib/abstract_controller/rendering.rb:103:in render_to_body' actionpack (3.2.13) lib/action_controller/metal/renderers.rb:28:inrender_to_body'
actionpack (3.2.13) lib/action_controller/metal/compatibility.rb:50:in render_to_body' actionpack (3.2.13) lib/abstract_controller/rendering.rb:88:inrender'
actionpack (3.2.13) lib/action_controller/metal/rendering.rb:16:in render' actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:40:inblock (2 levels) in render'
activesupport (3.2.13) lib/active_support/core_ext/benchmark.rb:5:in block in ms' /home/coblej/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/benchmark.rb:295:inrealtime'
activesupport (3.2.13) lib/active_support/core_ext/benchmark.rb:5:in ms' actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:40:inblock in render'
actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:83:in cleanup_view_runtime' activerecord (3.2.13) lib/active_record/railties/controller_runtime.rb:24:incleanup_view_runtime'
actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:39:in render' actionpack (3.2.13) lib/action_controller/metal/implicit_render.rb:10:indefault_render'
actionpack (3.2.13) lib/action_controller/metal/implicit_render.rb:5:in send_action' actionpack (3.2.13) lib/abstract_controller/base.rb:167:inprocess_action'
actionpack (3.2.13) lib/action_controller/metal/rendering.rb:10:in process_action' actionpack (3.2.13) lib/abstract_controller/callbacks.rb:18:inblock in process_action'
activesupport (3.2.13) lib/active_support/callbacks.rb:458:in _run__605160858__process_action__14466439__callbacks' activesupport (3.2.13) lib/active_support/callbacks.rb:405:in__run_callback'
activesupport (3.2.13) lib/active_support/callbacks.rb:385:in _run_process_action_callbacks' activesupport (3.2.13) lib/active_support/callbacks.rb:81:inrun_callbacks'
actionpack (3.2.13) lib/abstract_controller/callbacks.rb:17:in process_action' actionpack (3.2.13) lib/action_controller/metal/rescue.rb:29:inprocess_action'
actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:30:in block in process_action' activesupport (3.2.13) lib/active_support/notifications.rb:123:inblock in instrument'
activesupport (3.2.13) lib/active_support/notifications/instrumenter.rb:20:in instrument' activesupport (3.2.13) lib/active_support/notifications.rb:123:ininstrument'
actionpack (3.2.13) lib/action_controller/metal/instrumentation.rb:29:in process_action' actionpack (3.2.13) lib/action_controller/metal/params_wrapper.rb:207:inprocess_action'
activerecord (3.2.13) lib/active_record/railties/controller_runtime.rb:18:in process_action' actionpack (3.2.13) lib/abstract_controller/base.rb:121:inprocess'
actionpack (3.2.13) lib/abstract_controller/rendering.rb:45:in process' actionpack (3.2.13) lib/action_controller/metal.rb:203:indispatch'
actionpack (3.2.13) lib/action_controller/metal/rack_delegation.rb:14:in dispatch' actionpack (3.2.13) lib/action_controller/metal.rb:246:inblock in action'
actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:73:in call' actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:73:indispatch'
actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:36:in call' journey (1.0.4) lib/journey/router.rb:68:inblock in call'
journey (1.0.4) lib/journey/router.rb:56:in each' journey (1.0.4) lib/journey/router.rb:56:incall'
actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:612:in call' railties (3.2.13) lib/rails/engine.rb:479:incall'
railties (3.2.13) lib/rails/railtie/configurable.rb:30:in method_missing' journey (1.0.4) lib/journey/router.rb:68:inblock in call'
journey (1.0.4) lib/journey/router.rb:56:in each' journey (1.0.4) lib/journey/router.rb:56:incall'
actionpack (3.2.13) lib/action_dispatch/routing/route_set.rb:612:in call' warden (1.2.3) lib/warden/manager.rb:35:inblock in call'
warden (1.2.3) lib/warden/manager.rb:34:in catch' warden (1.2.3) lib/warden/manager.rb:34:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/best_standards_support.rb:17:in call' rack (1.4.5) lib/rack/etag.rb:23:incall'
rack (1.4.5) lib/rack/conditionalget.rb:25:in call' actionpack (3.2.13) lib/action_dispatch/middleware/head.rb:14:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/params_parser.rb:21:in call' actionpack (3.2.13) lib/action_dispatch/middleware/flash.rb:242:incall'
rack (1.4.5) lib/rack/session/abstract/id.rb:210:in context' rack (1.4.5) lib/rack/session/abstract/id.rb:205:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/cookies.rb:341:in call' activerecord (3.2.13) lib/active_record/query_cache.rb:64:incall'
activerecord (3.2.13) lib/active_record/connection_adapters/abstract/connection_pool.rb:479:in call' actionpack (3.2.13) lib/action_dispatch/middleware/callbacks.rb:28:inblock in call'
activesupport (3.2.13) lib/active_support/callbacks.rb:405:in _run__263562403__call__632775830__callbacks' activesupport (3.2.13) lib/active_support/callbacks.rb:405:in__run_callback'
activesupport (3.2.13) lib/active_support/callbacks.rb:385:in _run_call_callbacks' activesupport (3.2.13) lib/active_support/callbacks.rb:81:inrun_callbacks'
actionpack (3.2.13) lib/action_dispatch/middleware/callbacks.rb:27:in call' actionpack (3.2.13) lib/action_dispatch/middleware/reloader.rb:65:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/remote_ip.rb:31:in call' actionpack (3.2.13) lib/action_dispatch/middleware/debug_exceptions.rb:16:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/show_exceptions.rb:56:in call' railties (3.2.13) lib/rails/rack/logger.rb:32:incall_app'
railties (3.2.13) lib/rails/rack/logger.rb:16:in block in call' activesupport (3.2.13) lib/active_support/tagged_logging.rb:22:intagged'
railties (3.2.13) lib/rails/rack/logger.rb:16:in call' actionpack (3.2.13) lib/action_dispatch/middleware/request_id.rb:22:incall'
rack (1.4.5) lib/rack/methodoverride.rb:21:in call' rack (1.4.5) lib/rack/runtime.rb:17:incall'
activesupport (3.2.13) lib/active_support/cache/strategy/local_cache.rb:72:in call' rack (1.4.5) lib/rack/lock.rb:15:incall'
actionpack (3.2.13) lib/action_dispatch/middleware/static.rb:63:in call' railties (3.2.13) lib/rails/engine.rb:479:incall'
railties (3.2.13) lib/rails/application.rb:223:in call' rack (1.4.5) lib/rack/content_length.rb:14:incall'
railties (3.2.13) lib/rails/rack/log_tailer.rb:17:in call' rack (1.4.5) lib/rack/handler/webrick.rb:59:inservice'
/home/coblej/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/httpserver.rb:138:in service' /home/coblej/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/httpserver.rb:94:inrun'
/home/coblej/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/server.rb:191:in `block in start_thread'

Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/actionpack-3.2.13/lib/action_dispatch/middleware/templates/rescues/_trace.erb (4.1ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/actionpack-3.2.13/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (1.9ms)
Rendered /home/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/actionpack-3.2.13/lib/action_dispatch/middleware/templates/rescues/template_error.erb within rescues/layout (31.5ms)

Show page uses the original image, instead of a scaled-down version.

Should we produce 2 derivatives (thumbnail and preview) or could we make the thumbnail larger so it can be used for both purposes?

Permissions form should use nested permissions

Sufia needs to re-do how we use the permissions property. So, stop overriding it, and use the version that is in hydra-head. Change the permissions form to use nested attributes and the associated javascript.

Nested permissions: https://github.com/projecthydra/hydra-head/blob/7b3bc48a56a93de19b2c71ac9545b1a26eb6b0bf/hydra-access-controls/app/models/concerns/hydra/access_controls/permissions.rb#L16

Here's where sufia overrides it: https://github.com/projecthydra/sufia/blob/3db966d44fd527ed624f8c6b67d09e0fcf59f2e2/sufia-models/lib/sufia/models/generic_file/permissions.rb#L20-L35

Form:
https://github.com/projecthydra/sufia/blob/208258e0f974c270e8f63af6a9a8a6daa2045137/app/views/generic_files/_permission_form.html.erb

Javascript:
https://github.com/projecthydra/sufia/blob/208258e0f974c270e8f63af6a9a8a6daa2045137/app/assets/javascripts/sufia/permissions.js

set_title_and_label unnecessary?

set_title_and_label (in sufia-models/lib/sufia/models/jobs/unzip_job.rb) is unnecessary because label= calls title= at sufia-models-2.0.1/lib/sufia/models/generic_file.rb:147

Can we just set label instead?

auto complete vocabs not defined for multiform

The autocomplete_vocab defined here: https://github.com/curationexperts/sufia/blob/9db8a5510b9df7a283aedc1639270c5879722aa8/app/assets/javascripts/sufia.js#L141

is not available here: https://github.com/curationexperts/sufia/blob/master/app/assets/javascripts/sufia/edit_metadata.js#L7

This causes the add button to just submit the form instead of adding a field.

uninitialized constant Sufia::Models::AccessRight

Hello,

I get this error "uninitialized constant Sufia::Models::AccessRight" when I try to access this page http://localhost:3000/files/8049g505r/edit.

I think the cause is that I don't have the sufia-models folder in my rails project but when I copy it, it does not work also, I don't know how to make this work.

Can you help me please ?

Sufia::Models gemspec is including all of sufia

Given that Sufia and Sufia::Models are in the same git repository
When the gemspec files are determined via git ls-files
Then the list of files includes all files in the sufia repository instead of the sufia-models subdirectory.

Edit Profile link throws Routing Error

Clicking on the "Edit Your Profile" link on the user page as seen on the image below, causes a Routing Error

However, the "edit profile" link from the user dropdown menu, does work.

I've listed the different URLs for reference.

http://localhost:3000/users/d.cliff%40neu.edu/edit - broken
http://localhost:3000/users/d-dot-cliff@neu-dot-edu/edit - working

The difference seems to be that there is some escaping being performed on line 27 of https://github.com/projecthydra/sufia/blob/master/app/views/users/show.html.erb that causes the malformed URL

Can't mass-assign protected attributes: password, password_confirmation

Ran into this after doing the install and trying to signup a new user:

ActiveModel::MassAssignmentSecurity::Error in Devise::RegistrationsController#create

Should be an easy fix of adding password, password_confirmation to attr_accessor. I'd do this myself, but I couldn't get the test frameworks up and running.

Replace Sufia::GenericFile::Thumbnail#scale_image with change_geometry

Something like this:

    xfrm.change_geometry!('120x120') do |cols, rows, img|
     img.resize!(cols, rows)
    end

dashboard controller json responses Edit

Need to be able to find generic files for collections

Generic File controller json responses Edit

Need json responses for collections view to show GFs in the collection

dashboard file list modal

View to show json response in a modal for us in colletions edit and upload

Generate a solr_document_spec for target applications

Given Sufia is generating a SolrDocument (app/models/solr_document.rb)
Then Sufia should also generate an associated spec
And Sufia should also expose a shared_example 'is_a_sufia_solr_document'

The 'is_a_sufia_solr_document' would define the basic methods that should be implemented for the solr_document as well as any required/expected behavior.

its(:noid) { should == fedora_object.noid }
its(:to_model) { should == fedora_object.class }

Wrap inner bundle install with "travis_retry"

The inner bundle install fails somewhat regularly on TravisCI because the connection with Rubygems times out. The Travis folks suggest wrapping that in "travis_retry"

See:

https://github.com/projecthydra/sufia/blob/master/tasks/sufia-dev.rake#L59
https://twitter.com/travisci/status/377134757525876736

We should do this in a way that does not break the behavior locally.

Collection show view Edit

need a collection show view

ResolrizeJob reindexes all objects in fedora not just those in the namespace

I recently submitted a patch to ActiveFedora to allow the reindex everything to be limited to those items matching an arbitrary query (i.e. scoped to a namespace)

samvera/active_fedora#161

sufia-models should have a generator for config/initializers/redis_config.rb

Currently the generator is only in sufia, but someone working just with sufia-models will need that file.

Dashboard looks bad on firefox

sufia-models doesn't know about Sufia.config

`method_missing': undefined method `noid_template' for #<Rails::Engine::Configuration:0x007fb83a0ab2f8>
    from /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:21:in `noid_template'
    from /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:24:in `<module:IdService>'

lib/sufia/models/file_content/extract_metadata.rb:17:        tmp_base = Sufia.config.temp_file_base
lib/sufia/models/file_content/extract_metadata.rb:55:          Sufia.config.fits_path
lib/sufia/models/generic_file/actions.rb:37:      if Sufia.config.respond_to?(:after_create_content)
lib/sufia/models/generic_file/actions.rb:38:        Sufia.config.after_create_content.call(generic_file, user)
lib/sufia/models/generic_file/audit.rb:80:            if days_since_last_audit < Sufia.config.max_days_between_audits
lib/sufia/models/generic_file/characterization.rb:45:        Sufia.config.fits_to_desc_mapping.each_pair do |k, v|
lib/sufia/models/generic_file/thumbnail.rb:19:        return unless Sufia.config.enable_ffmpeg
lib/sufia/models/generic_file/thumbnail.rb:21:        output_file = Dir::Tmpname.create(['sufia', ".png"], Sufia.config.temp_file_base){}
lib/sufia/models/generic_file/thumbnail.rb:25:          command = "#{Sufia.config.ffmpeg_path} -i \"#{f.path}\" -loglevel quiet -vf \"scale=338:-1\"  -r  1  -t  1 #{output_file}"
lib/sufia/models/generic_file.rb:77:      "#{Sufia.config.persistent_hostpath}#{noid}"
lib/sufia/models/id_service.rb:21:      Sufia.config.noid_template
lib/sufia/models/id_service.rb:26:    @namespace = Sufia.config.id_namespace
lib/sufia/models/jobs/ffmpeg_transcode_job.rb:22:    return unless Sufia.config.enable_ffmpeg
lib/sufia/models/jobs/ffmpeg_transcode_job.rb:36:    output_file = Dir::Tmpname.create(['sufia', ".#{file_suffix}"], Sufia.config.temp_file_base){}
lib/sufia/models/jobs/ffmpeg_transcode_job.rb:57:    Sufia.config.ffmpeg_path
lib/sufia/models/noid.rb:39:      Sufia.config.id_namespace
lib/sufia/models/user.rb:74:    trophies.map { |t| "#{Sufia.config.id_namespace}:#{t.generic_file_id}" }

Inappropriate not found response in downloads controller

      if can? :read, params["id"]
        asset = ActiveFedora::Base.find(params[:id], :cast=>true)
        # we can now examine @asset and determine if we should send_content, or some other action.
        send_content (asset)
      else 
        logger.info "Can not read #{params['id']}"
        redirect_to "/assets/NoAccess.png"
      end

see: https://github.com/projecthydra/sufia/blob/64ad2adf3825637e40fd2bccb330bf3b67abddfe/lib/sufia/downloads_controller_behavior.rb#L34

While this might be okay if they requested an image, it seems completely wrong for any other data type. Can we just render text: 'no access', status: 401 or raise Hydra::AccessDenied?

generic_files/_show_details.html.erb triggers audit in the request

See:
https://github.com/curationexperts/sufia/blob/73789152ed4bdd3e688e64ebde42953ad58f113a/app/views/generic_files/_show_details.html.erb#L22

This can take a very long time (40s for me.) Can't we do it in the background?

Furthermore, we ought to do this in a controller, not a view.

ATTN @mjgiarlo @Cam156

"cannot load such file -- sufia/http_header_auth"

I'm following the README instructions and when I get to the rake fixtures step in the instructions, I get a the following error:

cannot load such file -- sufia/http_header_auth

I am unable to find the Sufia::HttpHeaderAuth class.

Sufia-Models local table dependent on Sufia generator

The stand alone sufia-models gem does not function as a stand alone gem. It is dependent on a local database table called 'version_comitters' that is only created as part of a sufia generator in https://github.com/projecthydra/sufia/blob/master/lib/generators/sufia/templates/migrations/create_version_committers.rb

Add section about contributing to Sufia to README

See https://github.com/projecthydra/hydra/blob/master/CONTRIBUTING.md for a thorough example of this, or the "Contribute" section of ScholarSphere's README which is more succinct: https://github.com/psu-stewardship/scholarsphere/blob/develop/README.md

bg_flat_75_ffffff_40x100 png image is missing

referenced in jquery-ui.css

Add rake task to release all sufia* gems

As per the 2013-06-10 Hydra committers call (https://wiki.duraspace.org/display/hydra/Committers+Call+2013-06-10), we will be keeping the sufia and sufia-models gem together.

Going forward sufia and sufia-models should have the same version number, similar to HydraHead and its components.

In addition a rake task (rake all:release) should be created to manage this.

Collections New View Edit

Need a collections new view

Update to Rack 1.4.5?

Looks like a new critical security update is out:

http://rack.github.com/

<ArgumentError: marshal data too short> if largish abstract entered

In a new app using Sufia (9be44ef), I see a marshal data too short error in the resque output. (https://gist.github.com/4651775)
This error occurs if an abstract is provided which is longer than a few words.
In the sample, it consisted of 2 lines - total 387 characters.

/Users/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-3.3.0/lib/sufia/dashboard_controller_behavior.rb:20:in `<module:DashboardControllerBehavior>': uninitialized constant Hydra::BatchEditBehavior (NameError)
    from /Users/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-3.3.0/lib/sufia/dashboard_controller_behavior.rb:18:in `<module:Sufia>'
2:56
    from /Users/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/sufia-3.3.0/lib/sufia/dashboard_controller_behavior.rb:17:in `<top (required)>'

and

/Users/coblej/.rvm/gems/ruby-1.9.3-p327@sufia/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require': cannot load such file -- hydra/collections (LoadError)

Fixed by adding these lines to the Gemfile

 gem 'hydra-batch-edit', '~> 1.0.2'
 gem 'hydra-collections', '~> 1.0.0'

we should add these dependencies to the sufia.gemspec

Sufia should not use solr_prefix from the datastream class name.

When the name of the datastream class changes, the whole application is broken.

Instead, use the dsid as the prefix.

sufia-models doesn't know about Sufia::Engine

     NameError:
       uninitialized constant Sufia::Engine
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:46:in `next_id'
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:36:in `block in mint'
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:34:in `synchronize'
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/id_service.rb:34:in `mint'
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/sufia-models-0.1.2/lib/sufia/models/active_fedora/redis.rb:4:in `assign_pid'
     # /Users/justin/.rvm/gems/ruby-2.0.0-p0@rails3/gems/active-fedora-6.2.0/lib/active_fedora/unsaved_digital_object.rb:32:in `save'

samvera-deprecated / sufia Goto Github PK

sufia's People

Contributors

Stargazers

Watchers

Forkers

sufia's Issues

./spec/lib/sufia/id_service_spec.rb

Recommend Projects

Recommend Topics

Recommend Org