samsung-cnct / careen Goto Github PK

New:

• what is the process for adding a patch to our docker build

Old:
Find a docker patch that we should use for two reasons:

a. increases the stability of the version of Docker we are going to ship with
b. exercise careen in jenkins

A vulnerability CVE-2016-9962 has been found which may involve docker. Please check the release notes to see if any action needs to be taken.

Commit hashes are currently recommended within manifest, but not required, because code has only been implemented to checkout by tag. We should implement git2go code to checkout by hash and require hashes since they are more robust than tags.

Currently if you attempt to clone a repository into an existing directory careen will fail as follows:

rodin:careen-davidewatson dwat$ go build && ./careen-davidewatson clone
INFO: Using careen config file: /Users/dwat/workspace/careen-davidewatson/config.yaml
INFO: Cloning packages from manifest ./manifests/docker.yaml
INFO: Cloning package docker from https://github.com/docker/docker.git to ./src/docker
█▒▒▒▒▒▒▒▒▒ ERROR: './src/docker' exists and is not an empty directory
ERROR: Failed to clone repo https://github.com/docker/docker.git to destination ./src/docker
rodin:careen-davidewatson dwat$ 

Instead careen should check if the directory contains the correct repository, checkout the master branch, update it if necessary, and checkout the requested tag.

This is dependent on #12. We must only upload artifacts only if they pass integration tests. We will reuse the integration tests provided by the repository maintainer if possible.

in the spirit of leaving CoreOS unmodified after it hits a node we should be creating our own CoreOS image with docker pre-installed

The reason we built careen is that we have some packages which require patches. For these packages we should have manifests and artifacts should be generated when the manifest changes. Initially docker will be the only manifest we test.

There are a few options for triggering the JJB job:

1. Careen changes
2. A manifest or patch file changes
3. ?

We need to select one and implement a JJB job to build artifacts and upload them to a well known location (presumably S3).