samsoir / kohana-gravatar Goto Github PK

With the latest commit, line 88, its calling a method 'email' however its a property. Disaster ensues.

Seems to be a typo, this section should be changed as follows:
250: throw new Gravatar(printf('The url %s is improperly formatted', $url));
Should read:
250: throw new Gravatar_Exception(printf('The url %s is improperly formatted', $url));

If I use something like Gravatar::instance('[email protected]', 'config'), it doesn't load default config, so I must fill all configuration settings. Also, failed Kohana::config() will return FALSE instead of NULL.

Fix:

    elseif (is_string($config))
    {
        if (FALSE === ($config = Kohana::config('gravatar.'.$config)))
            throw new Gravatar_Exception(printf('Gravatar.__construct() , Invalid configuration group name : %s', $config));

        $this->_config = $config + Kohana::config('gravatar.default');
    }

Please, add default view (gravatar/image) to project.

(I used old view gravatar/image for it)
Default view uses $src and $attr variables, so here is fix for render():

    $data = array('attr' => array(), 'src' => $this->_generate_url());

    if ($this->_attributes)
        $data['attr'] += $this->_attributes;

    $data['attr']['alt'] = $this->_process_alt();