Giter Club home page Giter Club logo

maestral-qt's People

Contributors

10b14224cc avatar dependabot-preview[bot] avatar lyzardking avatar samschott avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

maestral-qt's Issues

maestral-qt 1.8.0.dev0 does not start

Hi,

$ maestral gui
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.11/maestral", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/maestral/cli/cli_core.py", line 306, in gui
    run = entry_point.load()
          ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/importlib_metadata/__init__.py", line 209, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/lib/python3.11/site-packages/maestral_qt/main.py", line 45, in <module>
    from .setup_dialog import SetupDialog
  File "/usr/lib/python3.11/site-packages/maestral_qt/setup_dialog.py", line 16, in <module>
    from .utils import MaestralBackgroundTask, icon_to_pixmap, is_empty
  File "/usr/lib/python3.11/site-packages/maestral_qt/utils.py", line 21, in <module>
    from .resources import rgb_to_luminance
  File "/usr/lib/python3.11/site-packages/maestral_qt/resources/__init__.py", line 24, in <module>
    APP_ICON_PATH = resource_path("maestral.png")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: resource_path() missing 1 required positional argument: 'resource'

I think it is because you have a declaration with 2 parameters above:

def resource_path(package: str, resource: str):

Choose tray icon color

Can we have an option to choose tray icon color, instead of it trying to choose automatically?

At least on KDE it frequently fails and we have light tray icon on light taskbar :(

Python 3.10. Builtin and extension functions that take integer arguments no longer accept Decimals, Fractions and other objects that can be converted to integers only with a loss

Original issue here. samschott/maestral#509 (comment)

From the python 3.10 changelog:

bpo-37999: Builtin and extension functions that take integer arguments no longer accept Decimals, Fractions and other objects that can be converted to integers only with a loss (e.g. that have the int() method but do not have the index() method).

I think this is the problematic line:
https://github.com/SamSchott/maestral-qt/blob/853eb8d32ec3740c1ddfae4fbbbae9ab03e81459/maestral_qt/setup_dialog.py#L70

changing it to

width = self.pushButtonAuthPageCancel.width() * 1.1
width = int(width)

made it work for me. I'm not sure if this is the appropriate fix or if there should be some version check that we're above 3.10 before converting to an integer. Let me know what you think and I'll be happy to make a PR.

Require exact maestral version

I recently accidentally updated the maestral package via pip but forgot to update the maestral-qt package. I was running maestral v1.7.1 with maestral-qt v1.6.5. I assume there is no guarantee of compatibility in a scenario like this? Or maybe there is currently a compatibility guarantee but not between a future maestral v2.x.x and maestral-qt v1.x.x?

Currently this package depends on any greater or equal version of maestral, but setting it to the exact version should cause pip to show a warning updating one and not the other.

maestral>=1.7.1

Legacy maestral-qt with Qt4 support?

@samschott Is it possible to build maestral-qt 1.3.1 with PyQt4 instead?

Why bother: I wanna have maestral with GUI working on older macOS, in particular PowerPC ones. The last watchdog version to build there is 0.10.3, which corresponds to maestral 1.3.1, apparently. (It may be possible to build a somewhat later watchdog by adding fallback code for fsevents, but I have no idea if that will work with a newer version of maestral.)
Building maestral-cocoa is likely to be problematic on older macOS if possible at all. (Or if nothing compiles there, then it is likely not to work correctly anyway.) Qt-based option seems much more realistic, however Qt5 is broken on PowerPC and even older Intel. Qt4 works nicely and reliably though.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.