Comments (5)
Yes, thanks for spotting this question up -- it also requires some
clarification. In the beginning it was only the sequential approach elaborated,
i.e. it is obvious here what's happening:
CmdLineOptions c = new CmdLineOptions(); //all documented defatuls
c.setEnemies("g:10"); // 10 goombas
c.setInvulnerable(true); // defaults, but 10 goombas and Mario is invulnerable
to creatures.
WOuld you say that c.setArgs("...") should be invariant w.r.t. place it appears
and c.setEnemies("g:10") should drop
In this case the cumulative changes are a bit harder to "collect". Now, the
class does it for you, and by keeping track what's there, one can tweak the
levels in a desired way. Otherwise in GamePlay it will be necessary to spot
each additional parameter explicitly as CmdLineOptions class will not store all
the changes step-by-step. Yet the initial idea of using hash map was also this
one: to keep track of previous changes.
I came up with this idea: CmdLineOptions.reset() method, that drops all options
to defaults and is called whenever required. This will keep current behaviour
and would allow to have invariants of set of options that uniquely define the
level.
Original comment by [email protected]
on 29 Oct 2010 at 9:45
from marioai.
[deleted comment]
from marioai.
[deleted comment]
from marioai.
I can definitely see the convenience of being able to build up options, and
like your solution of adding a reset(). This way if someone was worried about
it and wanted to set everything explicitly they could call reset() and not have
to worry.
Thanks.
Original comment by [email protected]
on 29 Oct 2010 at 9:56
from marioai.
This issue was closed by revision r642.
Original comment by [email protected]
on 10 Nov 2010 at 7:20
- Changed state: Fixed
from marioai.
Related Issues (18)
- Incorrect comparison in LevelScene.getEnemyFloatPos() HOT 3
- LevelSceneTest: testGetSerializedLevelSceneObservationZ fails HOT 4
- MarioAIBenchmarkTest fail due to conversion to intS HOT 3
- evaluateSubmission in LearningEvaluation doesn't use learningAgent to run simulations HOT 6
- Replays cause a null pointer exception HOT 5
- Replays cause a null pointer exception HOT 2
- Running a replay on a file with visibility turned off causes a bug. HOT 2
- Max values in evaluation info are nonsensical HOT 3
- Level Generation is not consistent between certain runs using the same environment. HOT 11
- Recorder doesn't use level.lvl when run the normal way HOT 2
- -server option missing for TCP HOT 6
- getLevelSceneZ returns 19 x 19 grid HOT 5
- testScaredShooty G10RK5 and GW10G10 fail HOT 3
- Current Unit Test Failures HOT 2
- build.xml is not portable
- getintermediateReward
- Documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marioai.