samcorcoran / murdershegenerated Goto Github PK

Function makes sure that if a character has a relationship of a given type (e.g. professional) then they must belong to a suitable entity (e.g. a company). However, it should iterate over all of characters relationships of given type to ensure an entity is created for each (where applicable ).

Characters can already belong to multiple entities of the same type (e.g. Two companies) providing the numAllowed permits it.

Consider characters A, B, C, D each of whom has a professional relationship with the next. Assume companies must only have two members. If A is processed first then the BFS will create a company with characters A & B. If D is then processed then BFS will create a company with characters D & C. Processing B or C should create a third company, but at present the code will see they each have a professional entity they are associated with and so will move on.

A fix might iterate over rels of type and check if other chars in those relationships are already jointly members of an appropriate entity. This would have to occur AFTER an entity has completed its BFS to avoid bad interactions.

Raises questions as to whether entities behind relationships should be explicit (perhaps with relationships as their own class).