samcomber / spacv Goto Github PK

Watching these updates roll in is very exciting :)

I wanted to just make a minor suggestion: the geopandas.points_from_xy can be significantly more efficient than the list comprehension + shapely.geometry.Point() strategy used here.

This is mainly because of efficiency gains made using pygeos, which vectorizes the creation of the points. I'd use this wherever you're casting from arrays to geopandas.Geo* containers.

"UserWarning: CRS mismatch between the CRS of left geometries and the CRS of right geometries."

^ getting this for every fold, unsure if it's a critical concern.

Any advice?

Hi there,

I have the latest version of shapely and it doesn't seem to recognise 'asPolygon'. Has this been depreciated from shapely?

import spacv
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\x\Documents\spopt_venv\lib\site-packages\spacv_init_.py", line 5, in
from .spacv import *
File "C:\Users\x\Documents\spopt_venv\lib\site-packages\spacv\spacv.py", line 7, in
from .grid_builder import construct_blocks, assign_pt_to_grid
File "C:\Users\x\Documents\spopt_venv\lib\site-packages\spacv\grid_builder.py", line 3, in
from shapely.geometry import Polygon, asPolygon
ImportError: cannot import name 'asPolygon' from 'shapely.geometry' (C:\Users\x\Documents\spopt_venv\lib\site-packages\shapely\geometry_init_.py)

Any recommendations would be greatly appreciated :)

P