saltstack-formulas / gitlab-formula Goto Github PK

Hi,

Using the gitlab.runner seems to fail because the registering command requires the executor to be chosen. What about adding a gitlab.runner.executor (maybe defaulting to shell) variable ?

When doing a install of this gitlab-formula on a clean Debian 7 minimal install, the nginx service state fail mentioning that server_names_hash_bucket_size 32; is not enough.

After commenting out "server_names_hash_bucket_size 64;" in the nginx.conf file, nginx starts up successfully.

I have an internal formula we use for GLCI with the newer toml configs and auto configures it. Might be interesting to integrate that into this global gitlab formula.

Another thing is that on Debian we always use the omnibus installer, but it isn't mentioned anywhere in this formula. Was this intended to be a replacement for some of the Chef auto configuration in GitLab itself or was this because of historical reasons?

Please see this discussion:
https://groups.google.com/forum/#!topic/salt-users/Mlr7oITFqZw
basically the guitlab formula conflicts with the git formula and should rather include/depend on it.

Hi,

When I have a debian 7 minimal install, it seems sudo was not installed, but is required by this gitlab-formula to get a proper install going, otherwise the states where commands must be run as the git user fail.

The conf file should probably be checked in /etc/gitlab-runner/config.toml rather than in the home to allow configuration in

Also this is not idempotent as the register is not either... Maybe we can use gitlab-runner verify to check if the configured runner is already registered?

Hi,

Which postgresql salt formula do you guys which is a requirement in init.sls?

I can only find postgres-formula from https://github.com/saltstack-formulas/postgres-formula which has a folder postgres.

This also flows over into postgresql.sls which requires postgresql-server.pkg and .service. If I want to use the postgres formula from the above url, I need to change init.sls to require postgres instead of postgresql, and the lines in postgresql.sls in this gitlab formula:

from:
require:
- pkg: postgresql-server
- service: postgresql-server

to:
require:
- pkg: postgres-server
- service: postgres-server

Hi,

trying a recent install of this gitlab-formula, some of the bundler commands fail, and it seems updating to more recent versions vs what is suggested in pillar.example resolves the issue.

from:
shell_version: v1.8.0
gitlab_version: 6-5-stable

to:
shell_version: v1.9.4
gitlab_version: 6-9-stable

According to https://docs.gitlab.com/runner/install/linux-repository.html

We can use packages.gitlab.com as an apt source to deploy gitlab-runner. I think that would be a more elegant (and upgradable) solution.