salsita / go-pivotaltracker Goto Github PK

New features have been added and a new release should be cut on the 1.x.x branch so people get those in gopkg

Hi, Thanks for the library!! 😃

However, there is no support for Account Memberships API in the library as of now, it would be better if we also have that service developed.

Nevertheless, I am really in need of that service, so I am developing that part of the library under our forked version https://github.com/iReflect/go-pivotaltracker.

Please let me know if you have anything in your plans for the same.

P.S: I'll create a pull request for the same once its development is complete.

Thanks !!!

It looks like the code contains header comments for GPLv3 while the LICENSE file is MIT? Can you clarify which one applies?

Need to align to a linting standard to resolve the ID vs. Id thing that has creeped in. Add some type of free CI/CD tooling (Travis/Circle/Drone/???) and ensure linting is done on every commit/PR to maintain standard.

If you cut a release before this, gopkg.in will maintain compatibility and the release after fixing linting can become v2.0.0.

Right now, because all methods are concrete implementations, go-pivotaltracker can't be mocked, so it interferes with tests of functions that use it.
I'd be happy to take this on :)

Hi!

Would it be possible to update this package to be compatible with Go modules?

I think when I try to import it right now it's looking for a v5 module and failing, based on my understanding of https://github.com/golang/go/wiki/Modules#semantic-import-versioning, because of the v5 in the import path:

$ go build
go: finding github.com/salsita/go-pivotaltracker/v5/pivotal latest
go: finding github.com/salsita/go-pivotaltracker/v5 latest
go: downloading github.com/salsita/go-pivotaltracker/v5 v5.0.0-20181227212238-6d1834bca959
build github.maxmind.com/maxmind/mm_website.git/go/check-go-version: cannot find module for path github.com/salsita/go-pivotaltracker/v5/pivotal

I'm not sure the best way to address this unfortunately.

Thank you!