Giter Club home page Giter Club logo

cracking-the-coding-interview's People

Contributors

salma77 avatar

Watchers

 avatar

cracking-the-coding-interview's Issues

First Code Review

Chapter 1

Great

  • Good naming and clear docstrings
  • Modular code and good separation of helper functions

Can be better

  • docstring for helper functions is absent
  • in ArraysAndStrings::CompressString line 13 docstring parameter name doesn't match actual parameter name

Chapter 2

Great

  • Good encapsulation of data in data structure
  • Good naming of classes, functions and directories
  • Clear docstrings

Can be better

  • naming of nodes can be better node_1 for example instead of n1 7antafa

Chapter 3

Great

  • Good encapsulation of data in DataStructure
  • Using templates for types in stacks and queues
  • Inheritance where needed <3

Can be better

  • main function not needed in StacksAndQueues
  • Testing for AnimalShelter
  • function naming for queue could be more clear, since add and remove are quite vague, enqueue and dequeue might be better more 7antafa

Chapter 4

Great

  • Encapsulation and single responsibility
  • Great docstrings

Can be better

  • Naming
    • single character variables like x and g
    • similar names for classes Graph and Graph2
    • when I saw minBST I thought it was a heap for a minute :'D, maybe minHeightBST would be better
  • Manual Testing
    • testGetDepthList
    • testGraph

NOTE: if you want to do manual testing, that's fine, however, don't use the @Test decorator or even better, just assertTrue(true) at the end of the test.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.