cracking-the-coding-interview's People
cracking-the-coding-interview's Issues
First Code Review
Chapter 1
Great
- Good naming and clear docstrings
- Modular code and good separation of helper functions
Can be better
- docstring for helper functions is absent
- in
ArraysAndStrings::CompressString
line 13 docstring parameter name doesn't match actual parameter name
Chapter 2
Great
- Good encapsulation of data in data structure
- Good naming of classes, functions and directories
- Clear docstrings
Can be better
- naming of nodes can be better
node_1
for example instead ofn1
7antafa
Chapter 3
Great
- Good encapsulation of data in DataStructure
- Using templates for types in stacks and queues
- Inheritance where needed <3
Can be better
- main function not needed in
StacksAndQueues
- Testing for AnimalShelter
- function naming for queue could be more clear, since
add
andremove
are quite vague,enqueue
anddequeue
might be better more 7antafa
Chapter 4
Great
- Encapsulation and single responsibility
- Great docstrings
Can be better
- Naming
- single character variables like
x
andg
- similar names for classes
Graph
andGraph2
- when I saw minBST I thought it was a heap for a minute :'D, maybe
minHeightBST
would be better
- single character variables like
- Manual Testing
- testGetDepthList
- testGraph
NOTE: if you want to do manual testing, that's fine, however, don't use the
@Test
decorator or even better, justassertTrue(true)
at the end of the test.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.