salamek / gettexttranslator Goto Github PK

In our project we have separated modules and in order to prevent string clashes by merging all files to one instance of Gettext translator by using addFile we are creating instance of Gettext per module.

And this led to production-only bug as each Gettext translator uses the same cache directory-<lang>.

How to reproduce:

$translator = new Gettext($session, $storage, $response);
$translator->addFile($path, 'messages);
$translator->setProductionMode(true);

echo $translator->translate('Foo'); # Translated as "Goo"

$translator2 = new Gettext($session, $storage, $response);
$translator2->addFile($path, 'messages);
$translator2->setProductionMode(true);

echo $translator2->translate('Foo'); # Translated as "Bar", however "Goo" from cache obtainedfa

Considering two solutions:

1. Providing explicit tag to distinquish each instance (via constructor where the namespace could altered)
2. Use hash of absolute filepaths to distinquish cache (local update only in loadDictionary).

The first way seems more plausible as it also prevents related issues (for example with new strings in session).

I have encounered weird behaviour of Gettext::translate

Usage:

{_'%d images were uploaded and inserted.', 1}<br >
{_'%d images were uploaded and inserted.', 2}<br >
{_'%d images were uploaded and inserted.', 5}

Template:

msgid "%d images were uploaded and inserted."
msgid_plural "%d images were uploaded and inserted."
msgstr[0] ""
msgstr[1] ""

Translation:

msgid "%d images were uploaded and inserted."
msgid_plural "%d images were uploaded and inserted."
msgstr[0] "%d image was uploaded and inserted."
msgstr[1] "%d images was uploaded and inserted."

What I get:

1 image was uploaded and inserted.
2 image was uploaded and inserted.
5 image was uploaded and inserted.

It seems to me that the translate function is trying to use the argument as a index into translation array instead of clasifying which group it is and then using the group index.

Is that an error, I am using something not supported or the syntax for this usage is weird?