rzgry / express-rest-api-template Goto Github PK

The app is currently using the bin/www that was automatically generated by express generator.

So it has a whole bunch of linter warnings when ran against the eslint configuration.

Right now eslint is disabled in this file by this line:

Need to remove the /* eslint disable */ line and fix the linter warnings in bin/www

Can lint just that file by running npx eslint src/bin/www

Should probably just use eslint-disable-line for any no-console errors, and fix all of the other errors (such as no-var).

Ex:

...
console.log(`Listening on ${bind}`); // eslint-disable-line no-console
...

Current .travis.yml uses the default script which just runs npm test

https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#default-build-script

Would be nice to get travis to run both eslint (npm run lint) and the tests (npm test)

Example travis config with a linting step:
https://gist.github.com/ronapelbaum/ef3c3459f01b002d0d719ca205401174

Can you please specify your repo's license? Thank you.