rylandg / myos Goto Github PK

Based on the great suggestion here https://old.reddit.com/r/vim/comments/buwcel/myos_develop_and_share_terminal_environments/epix4b7/

Describe the bug
myos create rysenv fails because the generated docker-compose file is not supported by docker-compose. myos.sh generates version: "3.7".

To Reproduce
Follow the installation steps until you get to $ myos create rysenv then the problem arises

Expected behavior
The container runs succesfully

Host OS:

• Ubuntu 18.04
• Docker version 18.09.6, build 481bc77
• docker-compose version 1.17.1.

Additional context
Fixed it by changing version: "3.7" by version: "3" and then running docker-compose up -d and renaming the container for what myos.sh was looking for docker container rename mayosconfig_myos_1 rysenv_myos_1

At minimum Emacs flavor should exist

Describe the bug
When running in Ubutntu, myos.sh does not work:

⇒ ./myos.sh init
/bin/sh: 0: Illegal option -

The reason is probably that in ubuntu /bin/sh is a link to dash:

⇒ ls -lah /bin/sh
lrwxrwxrwx 1 root root 4 gen 14 11:37 /bin/sh -> dash*

One solution would be to use bash in the script or adapt the script to work also with dash

To Reproduce
Just run in Ubuntu 19.04 should be the same in other versions)

Expected behavior
It should not exit immediately :)

Host OS (please complete if relevant):

• Ubuntu 19.04, but any recent Ubuntu should behave the same

Describe the bug

Probably missing something obvious here. I'm running Git bash on Windows. Was curious to try this out and followed the README instructions. All good until myos create. Keys are created fine but then got the error in the title. Same if I try to connect:

$ myos connect testmyos
Could not open a connection to your authentication agent.

I am not using OpenSSH but Putty instead. Tried to spawn the Putty SSH authentication agent (Pageant) to no avail.

Host OS (please complete if relevant):

• OS: Git Bash on Windows 10

Describe the bug

There are a lot of small details that need to be examined when running multiple containers at once. The biggest issue is in regards to mounting multiple containers on the same volumes.

To Reproduce

Run multiple instances of MyOS

Otherwise the terminal can't set the colors correctly.

@benyanke nano PR was just accepted so the README should reflect that addition!

No feedback/error when repo is missing
myos create foo does not return an error or fail if the repo is missing. It just runs forever. Running docker-compose up -d by hand returns:

Pulling myos (myos:latest)...
ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing.

Continue with the new image? [yN]y
Pulling myos (myos:latest)...
ERROR: pull access denied for myos, repository does not exist or may require 'docker login'

To Reproduce
Steps to reproduce the behavior:

1. install myos via npm
2. init the template
3. run myos create foo
4. the command will run until interrupted. I let it run for over an hour before I killed it.

Host OS (please complete if relevant):

• OS: macOS
• Version 10.14.5

MyOS requires specific versions of docker-compose and docker engine and they should be directly communicated in the README

To Reproduce
Run MyOS with an old version of docker/docker-compose

I was trying to take a look at myos.sh, the code is clean and readable but not easy to understand for beginners.

That's why I suggest commenting on every part of this file to make it easier to understand.

If you want I can do it and open a pull request.

Hey Rylan! Can we get in touch? I noticed you invited me to collaborate on this project, if it was a mistake - don't sweat it, i won't accept it and I won't harm this project in any way.

Not sure this is in the scope of this project (great idea, BTW), but I'd like to have a way to "extend" this concept more.
My point is: I use a slightly different set of tools, like nvim and sometimes atom. Or oh-my-ssh with zsh.
With current implementation, we have to use what is installed in the Dockerfile (we can customize only through docker-compose).

Obviously, I can install what I need just specifying a Dockerfile for my docker-compose that extends rylandg/myos:latest image. However, this still installs stuff I don't need (vim instead of nvim).
So wondering if we could have template docker-compose using a local Dockerfile in templates that can be customized, extending the base rylandg/myos:latest that would define only what is strictly necessary (e.g. SSH connectivity, user configuration). We might document how to extends for more common tools.

Again, this is probably out of scope for this project, so feel free to ignore this :).

Hi Ryland,

This is not really an issue but a question to help me understand the project better.
Why is there a need to run a SSH server inside each container? why docker exec -it name-of-container sh is not enough?

I've used Docker in a similar fashion in the past to run a live coding environment, basically a similar goal as this project.

Describe the bug
Ubuntu 19.04. When I connect, it ask me for a password.
Also, it tries to load all the keys in ~/.ssh (not sure this is on purpose), however failing because permission denied.

⇒ myos connect testmyos2
Identity added: /home/marco/.myos/myos-key (marco@darkav)
load pubkey "/home/marco/.ssh/id_rsa": Permission denied
( + other keys I have in ~/.ssh)
Warning: Permanently added '[localhost]:32770' (ECDSA) to the list of known hosts.
ubuntu@localhost's password:

To Reproduce
Start from scratch in Ubuntu 19.04 (remove all previous docker images, etc).

Expected behavior
Should connect without asking for a password

Screenshots
If applicable, add screenshots to help explain your problem.

Host OS (please complete if relevant):

• Ubuntu 19.04

Additional context
No additional context

Describe the bug
The Dockerfile for MyOS allegedly turns off password based login for incoming ssh connections. From testing in #15 it's clear that it's not the case.