package="uk.ryanwong.skycatnews" found in source AndroidManifest.xml: /Users/rwong/Documents/StudioProjects/sky-cat-news/app/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

This is to uncouple the dependency of the main composables with the viewmodels.
Only pass what it is needed from the navGraph, and we can then generate previews for all top-level screens.

There is not much performance boost to be expected, but just for being a sample app.
Generate using Android Studio automatically so it should not be too much effort.

Credits: Mouawia Hammo and Mohamed Ben Rejeb

This is a wider change affecting all projects that use Version Catalog. sky-cat-news is going to be a pilot and gradually the same change will be applied to all other projects.

Details:

Currently, some dependencies are grouped at the Version Catalog level using bundles.

coroutines = ["kotlinx-coroutines-core", "kotlinx-coroutines-android"]

and at the app-level build.gradle.kts, they are referenced like this.

    implementation(libs.bundles.coil)
    implementation(libs.bundles.coroutines)

Problems:

1. We can't mix usages like implementation, kapt, debugImplementation etc in one bundle. If we split them into two (or more) bundles, it violates the purpose for bundling them.

2. It can be hard to quickly know what dependencies are included in the bundle, especially when the project goes multi-module, so the lookup takes time.

Solution:

Group related dependencies under the same namespace, and we declare each dependency separately in build.gradle.tks like this:

    with(Deps.Google.DaggerHilt) {
        implementation(android)
        kapt(compiler)
    }

This takes a balance between showing what dependencies are in a group, and what we have included under that group. Auto-complete is also possible even if we manually build the dependency list- provided we have the prefix scoped.

Define dimension constants using Kotlin rather depending on Android Resources.
This is because we eventually have to handle multiple screen sizes using jetpack compose natively.

Copy existing work from other projects will do.

w: /Users/rwong/Documents/StudioProjects/sky-cat-news/app/src/main/java/uk/ryanwong/skycatnews/newslist/ui/screen/NewsListScreen.kt: (104, 9): 'SwipeRefresh(SwipeRefreshState, () -> Unit, Modifier = ..., Boolean = ..., Dp = ..., Alignment = ..., PaddingValues = ..., (state: SwipeRefreshState, refreshTrigger: Dp) -> Unit = ..., Boolean = ..., () -> Unit): Unit' is deprecated.
accompanist/swiperefresh is deprecated.
The androidx.compose equivalent of SwipeRefresh is Modifier.pullRefresh().
This is often migrated as:
Box(modifier = Modifier.pullRefresh(refreshState)) {
...
PullRefreshIndicator(...)
}

For more migration information, please visit https://google.github.io/accompanist/swiperefresh/#migration

https://github.com/Kotlin/kotlinx-kover/blob/v0.7.0/docs/gradle-plugin/migrations/migration-to-0.7.0.md

kotest is not bad.

It was just a tool I used when I was with Mission Labs. Not too popular being a transferable skill.
I see no chance I will be using this anywhere outside Mission Labs, which means it brings no advantages for me to stick to this.

Switching back to a more standard option like JUnit will be more practical.

Assertion library TBC.

⚠️ State of the Plugin ⚠️ - Seeking Interested Maintainers #569
JLLeitschuh/ktlint-gradle#569

https://github.com/diffplug/spotless
https://medium.com/swlh/spotless-on-android-3716459cecd7

Spotless looks promising. Ktlint Gradle has been quiet for most of the time.
If this works, all projects will be migrated to spotless.

Saw the version catalog generated by Android Studio Giraffe looks different from the current one.
Would be good to apply their version

Kover can generate report but the coverage is all zero

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Are we able to rewrite the Groovy build.gradle into build.gradle.kts?

It looks like more code samples and documentations are being delivered in KTS.

Properly exclude untestable classes

As I am leaving Sky, to continue playing with this project, it would be the best to remove all the Sky brandings and also the keyword "Sky".

• It will be just "cat news".
• Weblink will point to somewhere else but not Sky News.
• Project namespace and github repository name will be all changed, too.
• Screenshots have to be updated.

Try to rearrange dependencies using Gradle Version Catalog.
See what can be done, then apply to other projects.

Obviously this will be over-engineering for this tony demo app, but it is still worth splitting features and layers into modules for demo purposes.

Not much work is required except to set up gradle build scripts again.

Currently model conversion functions have been implemented within the companion objects of the model classes.

Received feedback suggesting that this would create a tight coupling between two layers.

A better way is to move those conversion functions to separate mapper classes. In this way, the models are no longer linked to the implementation of another model class.

First step to make this KMP. Migrate existing code to the KMP (Android + iOS + Desktop) project structure.
We will be using Compose Multiplatform therefore could be potentially be landing iOS pretty quickly.

Received feedback and valid issue:
When running this project on a fresh environment, we do not have, and not necessary to have the keystore to run the debug builds.
This applies to all other projects inheriting the same build process.

Changed to allow skipping the keystore check, and also make it more flexible.

Goals:

• when running the project to a fresh environment can have the errors removed
• configuration fit to work with Github Actions auto tests without a need to access to keystore, so we can automate Renovate PR approval and merging

If this works, it will be applied to all other projects.