Hello

First of all thanks for the lib. It helped me alot, as it implements signing. But I have one issue with failed requests.

Failed requests are console.loged and resolved on line:

Then it is impossible to get error reason.

I am overcoming the issue using own client. But I think it would be usefull to resolve and reject with whole bricklink data

See https://github.com/nodejs/release#release-schedule.

Current node version according to latest commits is 12. Current lowest LTS version is 18.

Hey ryansh100,
currently request getPriceGuide-request seems to be broken.
It leads to the following error:

node_modules/bricklink-api/src/client.js:68
let data = JSON.parse(body);
^
SyntaxError: Unexpected token < in JSON at position 0
at JSON.parse (<anonymous>)

Did the Bricklink Api, announce some changes?
Do you have time to investigate?

Hi,

I try to use your code to retrieve data from Bricklink but it does not work. Therefore I use the code following code and it works.

`'use strict';

const express = require('express');
const app = express();

const Client = require('bricklink-api').Client;
console.log('hi', Client);
const ItemType = require('bricklink-api').ItemType;
const bricklink = new Client({
"consumer_key": "",
"consumer_secret": "",
"token": "",
"token_secret": ""
});

app.get('/part/:id', function(req, res) {
bricklink.getCatalogItem('PART', req.params.id)
.then(function(part){
res.json(part)
});
})`

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Description of the issue

I was trying to make a web interface using ExpressJs and Bricklink-API.
The problem is errors handling.
When an error is sent from bricklink api, it is not caught in case there is a callback to the Client Send method.

Here is the diff that solved my problem:

diff --git a/node_modules/brickbase-bricklink-api/dist/client.js b/node_modules/brickbase-bricklink-api/dist/client.js
index 85b4a64..deba093 100644
--- a/node_modules/brickbase-bricklink-api/dist/client.js
+++ b/node_modules/brickbase-bricklink-api/dist/client.js
@@ -111,7 +111,7 @@ var Client = exports.Client = function () {
       });
 
       if (req.callback) {
-        promise.then(req.callback);
+        promise.then(req.callback).catch(req.callback);
       }
       return promise;
     }

This issue body was partially generated by patch-package.

Hi @ryansh100, thanks for the library, would you be able to add more data about errors from BrickLink? might want to throw an object instead of a string.

e.g.

const error = {
          resourceURL: resourceURL,
          responseMetadata: payload.meta,
        }

Would you accept a PR for that?

Although no methods exist yet, I want to share that the Client object cannot send PUT or POST requests.

The problem consists of multiple issues:

• There does not seem to be a way to provide a content body to a request. Whatever you do, the request parameters will always be sent as query string.
• There is no header Content-Type: application/json configured, even though it's required by BrickLink's API (not stated in docs, but error will be thrown when missing).
• The OauthHelper does not seem able to correctly sign requests containing a body.

These issues need to be addressed or expansion of the api wrapper cannot progress except for adding more GET requests.