ryanclark / flux-getting-started Goto Github PK

Sorry about the bad PR, had a few mins tonight to investigate and it looks like the issue is that .off should actually be .removeListener (doesn't seem to be an off method listed in the docs: https://nodejs.org/api/events.html). I also changed .on to . addListener for consistency

    addChangeListener: function (callback) {
        this.on('change', callback);
    },
    removeChangeListener: function (callback) {
        this.off('change', callback);
    },

To:

    addChangeListener: function (callback) {
        this.addListener('change', callback);
    },
    removeChangeListener: function (callback) {
        this.removeListener('change', callback);
    },

All in all, great course, absolutely loved it! I only realized that this was a bug after I started building more features on top of it, and the messages component wouldn't unmount properly :)

Hi Ryan,

Thanks for the great blog post! I'm trying to get the starter repo up and running, but am getting a 404 (Not Found) after running "gulp".

This is the output from my terminal:
[20:47:22] Starting 'server'...
[20:47:22] Finished 'server' after 2.32 ms
[20:47:22] Starting 'scripts'...
[20:47:22] Starting 'styles'...
[20:47:22] Starting 'copy:libs'...
[20:47:22] Finished 'copy:libs' after 2.95 ms
[20:47:22] Starting 'copy:html'...
[20:47:22] Starting 'watch'...
[20:47:22] Finished 'watch' after 14 ms
[20:47:22] Finished 'copy:html' after 53 ms
[20:47:22] app.js was reloaded.
[20:47:22] Finished 'scripts' after 242 ms
[20:47:22] gulp-ruby-sass: directory
[20:47:23] gulp-ruby-sass: write app.css
[20:47:23] gulp-ruby-sass: write app.css.map
[20:47:23] Finished 'styles' after 1.13 s
[20:47:23] Starting 'build'...
[20:47:23] Finished 'build' after 4.13 μs
[20:47:23] Starting 'default'...
[20:47:23] Finished 'default' after 5.74 μs
[20:47:23] app.css was reloaded.

I feel like something may be missing, but I can't pinpoint the issue. Thoughts?

Hi! I was eager to try out this project, but after running gulp I've got this error:

[14:35:20] Plumber found unhandled error: Error in plugin 'gulp-ruby-sass'
Message:
error /Users/gkbonetti/code/flux-getting-started/public/src/scss/partials/_messageBox.scss (Line 3: Invalid CSS after " &": expected "{", was "__list {"

"__list" may only be used at the beginning of a compound selector.)

I am new to React, but have a lot of experience with Ruby, SASS and AngularJS.
What am I doing wrong?