rxi / ini Goto Github PK

It's not really a problem or bug rather then a little inconvenience and warning to others.

I am working on screen locker, and I tried to tie it in with .ini parser - and this one was best of them all.

However, because this screen locker forks at some point, .ini get freed and char array contents get corrupted.

Again, I understand why such method was selected, but anyway, using *((const char**) dst) = val; is somewhat unreliable in such programs. I am now using strcpy to get content of string after getting value with ini_sget or ini_get.

Some non-standard libc's (such as on game SDKs or other embedded systems) do not do null checks before freeing memory. I think at least the free(ini->data) line in ini.c should have a check added there so there would not be a crash if a file is not found. Could this be done?

Thanks

how can i set value?

Program received signal SIGSEGV, Segmentation fault.
0x0000000000402964 in ini_get (ini=0x0, section=0x42b5eb "syslog", key=0x42b5e0 "serverAddr")
at CloudWaf/src/dt/modules/sign_check/ini.c:233
233 char *p = ini->data;
Missing separate debuginfos, use: debuginfo-install glibc-2.17-292.el7.x86_64 libgcc-4.8.5-39.el7.x86_64 libstdc++-4.8.5-39.el7.x86_64

It'd be useful to be able to test if a particular section exists before trying to read anything from it. This would allow for creating relevant structures in advance. And it would be especially useful in situations when you cannot rely on any key/value pair being always present if a section exists.

Is this something that could be supported without expanding existing API? e.g.,

ini_get(config, "owner", NULL) == NULL // section doesn't exist
ini_get(config, "owner", NULL) != NULL // section exists

If that sounds OK to you I could create a PR.