Package has dependencies on GitHub about async-pool HOT 11 CLOSED

Thanks for filing this issue. I'd like to understand your concern in a little more detail please. Note this is only needed/used on development. Is it about installation time or runtime? Thanks

from async-pool.

If it is only used in development you could just install it as an devDependency. It is currently installed as a normal dependency and gets installed by default if someone depends on tiny-async-pool.

The problem I have is git specific, but I don't want to use git for npm module resolution. If I install tiny-async-pool npm tries to install assertion module from your GitHub account (using git). This is uneccesary.

I work with Docker and try to keep my Images as small as possible so I don't want to install git if it is not necessary.

from async-pool.

Is is only about installation

from async-pool.

Thanks for the clarification, I understand your problem now. On each deployed server, you run npm install and installing the extra assertion module from github impacts your install time.

Why can't we make assertion a devDependency? Because, it's an actual dependency (that can be avoided user's staging/production environment). Note the difference between user's dependencies (i.e., dependencies) and async-pool development dependencies (i.e., devDependencies, e.g., mocha).

Why can't we use node's internal assert? Because what I have in assertion is actually a higher level abstraction. If we change assertion to use node's internal assert under the hoods we would still need to install it.

What can we do? I assume your application has dozen other dependencies and the problem is that assertion comes from github instead of npm. Would publishing assertion in npm (as regular package) instead of relying on github solve your problem?

Thanks

from async-pool.

Publishing assertion would be great and would solve my problem, but you would have to change the package name, because assertion is already used by another package.

from async-pool.

Done, that module was named yaassertion. New version released 1.0.2.

Fixed by ad1489a

from async-pool.

Please, let me know if you find any problems

from async-pool.

Thank you.

from async-pool.

The package yaasertion is not published on npm. [email protected] cannot be installed....

from async-pool.

My bad, I published to a wrong npm registry. Re-did it now https://www.npmjs.com/package/yaassertion, please can you check?

from async-pool.

Now it works. Thank you.

from async-pool.