don't throw on empty array about async-pool HOT 5 CLOSED

Actually, looking into this a little more the package behaves differently depending on NODE_ENV which I think is unexpected for a sub module.

For example, when I ran into this error I tried to write a failing test, and I couldn't get it to throw an error because my tests are run with NODE_ENV="test", so in my case it's pretty much not possible to write a failing test without reconfiguring my test suite just for this one minor issue.

If you feel this behaviour is appropriate, you should definitely include it in the readme.

I think the best way to avoid unexpected behaviour is to avoid changing behaviour based on NODE_ENV.

from async-pool.

The assertions are meant to help during development (development only) by throwing exceptions on maluse instead of doing best effort to make it work. On the other environments, it should make best effort to make it work.

That being said, I don't recall why there's this check Parameter array must have at least one item. I agree it makes sense to support empty array. Can you submit a PR with a fix? Thank you

from async-pool.

Is the assertion during development thing a common convention ? I'm an amateur, but I've never encountered this before. I guess I'm just wondering whether you think it's worth a mention in the readme.

from async-pool.

No. We see that in some libraries (e.g., react.js), but I'd say the common convention is typed JS solutions like TypeScript or Flow.

from async-pool.

Now that this has been merged, can an updated package be published?

from async-pool.