Giter Club home page Giter Club logo

prettyscribe's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

prettyscribe's Issues

Suggestion to add roster notes

Hi,

Currently it is possible to see custom names an notes on unit cards.

Would it be possible to add the general 'notes' also? Its under the Roster details tab on top and if you share the Battlescribe list it is added to the file under the list name.

image
image

Thanks!

40K 10 Edition Update

Iโ€™m getting a error message that Warhammer 40,000 10th Edition is not supported. Will there be a update to fix this? Thanks.

Load roster js function

The idea behind this feature is to use the prettyscribe website to host the roster and be able to add the roster file programmatically from a different source.

I would think of a javascript function that is called LoadRoster and accept either the xml content of the roster as a string. So we can load the website and call the function with the .rosz-file xml content and the roster is displayed.

I use the prettyscribe website in a WPF WebView2 control so opening the file selection dialog and inserting the path of the file is quite hacky. I can fire javascript functions in the control, so I would open the website in the webview2 control, read the contents of the rosz file and hand the content down to the javascript function so the roster is displayed in the control.

Output doesn't fit DIN A4 pages

As the title says, the output doesn't fit. Scaling down the print to 96% makes it work, but that is only a temporary solution.

Printing to PDF (or otherwise) doesn't work

Hi,

This app is awesome, and fully realize it's a WIP. Loading in a .rosz file works great, and the generated page is spectacular, but I want to print to PDF or HTML, and neither work.

When printing to PDF, all of the formatting and images are lost, so for example the rings around the base stats (move, save, bravery, wounds) disappear, making it pretty hard to read. When saving as HTML, it's even worse, although that's not really that surprising, being able to save to PDF is by far the preferred option. I'm on latest Windows, and I've tried with both Chrome, Firefox, and MS Edge.

Should note that I'm using this for Age of Sigmar rosters.

Change font size?

Whenever I print out the rosters the body text is ~2mm high, which is roughly 6pt. Is there some way to increase the font size?

Leadership value and rules bloat fix

the leadership is broken for Heresy as well it cuts off details when the rules become too long. I have attached pictures of what lines and what fixes I have done
prettyscribe fix 2
prettyscribe fix1

Canvas vs HTML+CSS

Have you considered using HTML+CSS to render data instead of canvas? Canvas has the downside that it doesn't scale well, and ends up looking a little fuzzy. I have a working demo for the renderer40k.ts, happy to clean it up and send a pull request if you'd like to take a look. LMK

Horus Heresy W30k .rosz not rendering

When I select a .rosz file from Warhammer 30k (2nd edition), nothing loads (blank page). This issue does not occur when I upload a W40k .rosz file.

Show possible Stratagems for each unit

There is this website https://40kroller.animetidd.is which allows to see all possible strategems for each phase for each unit. Is it possible to add such thing to PrettyScribe too?
Unbenannt

Or even have separate table where it is separated in different phases and tells e.g. MOVEMENT: Stratagem_Name1 for Unit_Name1, Unit_Name2 etc.
Unbenannt

Btw 40kroller developer wanted to cooperate with you, according to his Discord:
Unbenannt

Issue with ros file

When using a .ros file vs a rosz file it will interpret the file differently as the uncompressed file uses a Unicode character not an ASCII version as such it will show nonsense characters.
prettyscribe issue 3
prettyscribe issue 4

`npm start` no longer auto-reloads prettyscribe.js on localhost:8080

The iterative dev loop with npm start is no long updating or reloading dist/prettyscribe.js. It does compile prettyscribe.js though, and webpack claims the file is emited, but I'm not sure where it's emitted too. localhost:8080 doesn't reload, and a manual reload of the page loads the old version of prettyscribe.js.

Here's some output;
`$ npm start

[email protected] start /Users/smardan/Documents/GitHub/PrettyScribe2
webpack-dev-server

[webpack-dev-server] Project is running at:
[webpack-dev-server] Loopback: http://localhost:8080/
[webpack-dev-server] On Your Network (IPv4): http://192.168.86.193:8080/
[webpack-dev-server] On Your Network (IPv6): http://[fe80::1]:8080/
[webpack-dev-server] Content not from webpack is served from '/Users/smardan/Documents/GitHub/PrettyScribe2' directory
(node:28375) [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: Compilation.modules was changed from Array to Set (using Array method 'reduce' is deprecated)
(node:28375) [DEP_WEBPACK_MODULE_ERRORS] DeprecationWarning: Module.errors was removed (use getErrors instead)
asset prettyscribe.js 3.24 MiB [emitted] (name: main)
runtime modules 26.3 KiB 13 modules
modules by path ./node_modules/ 823 KiB
modules by path ./node_modules/webpack-dev-server/client/ 51.8 KiB 12 modules
modules by path ./node_modules/webpack/hot/.js 4.3 KiB 4 modules
modules by path ./node_modules/html-entities/lib/
.js 81.3 KiB 4 modules
modules by path ./node_modules/url/ 37.4 KiB 3 modules
modules by path ./node_modules/querystring/.js 4.51 KiB 3 modules
./node_modules/jszip/dist/jszip.min.js 93.5 KiB [built] [code generated]
./node_modules/ansi-html-community/index.js 4.16 KiB [built] [code generated]
./node_modules/events/events.js 14.5 KiB [built] [code generated]
./node_modules/lodash/lodash.js 531 KiB [built] [code generated]
modules by path ./src/
.ts 274 KiB 12 modules
webpack 5.55.0 compiled successfully in 3808 ms
Noticeasset prettyscribe.js 3.24 MiB [emitted] (name: main)` above. However, dist/prettyscribe.js is not updated.

I can manually update dist/prettyscribe.js by manually running npm run build after each edit:

`
$ npm run build

[email protected] build /Users/smardan/Documents/GitHub/PrettyScribe2
webpack

(node:28815) [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: Compilation.modules was changed from Array to Set (using Array method 'reduce' is deprecated)
(node:28815) [DEP_WEBPACK_MODULE_ERRORS] DeprecationWarning: Module.errors was removed (use getErrors instead)
asset prettyscribe.js 2.6 MiB [emitted] (name: main)
runtime modules 1.25 KiB 6 modules
modules by path ./src/*.ts 274 KiB 12 modules
modules by path ./node_modules/ 625 KiB
./node_modules/jszip/dist/jszip.min.js 93.5 KiB [built] [code generated]
./node_modules/lodash/lodash.js 531 KiB [built] [code generated]
webpack 5.55.0 compiled successfully in 3808 ms
`

`

Any idea what's up?

Hedonites and Long Datasheets

Seems certain units are not displaying when loaded with PrettyScribe (using AOS)

the points are entered (the units in the case are The Fane Of Slaanesh and Syll'esske The Vengeful Alliance)

alongside this, when printing, datasheets for Keeper Of Secrets and Shalaxi Helbane seem to either overlap eachother when it gets to their damage charts, or they can get hidden behind the next datasheet being printed
IT BROKEN
ROSTER TEST.zip

Suggestion: Single Page per Datasheet

Hey there! Love the app - the only thing i find missing (due to the way I like to put together binders for datasheets/stratagems with Buttscribe) is the option to print it off (admittedly wastefully) with just a single unit's datasheet per page. That option would be a great help. Thanks!

Age of Sigmar - Missing GHB Rules Section

Love Prettyscribe, what a great tool. Thanks!

I've noticed that the output for Age of Sigmar BS rosters doesn't include the section for GHB Rules (2023 in this case). Is this intentionally removed or a bug? It'd be great to have the relevant rules section added to the roster output from PS if possible.

Cheers

ghb 2023 rules

Black Coach's Evocations are not ordered

A spin-off of #66

Summary: The Black Coach (Death - Nighthaunt) has 5 Evocations of Death it gets and they are normally presented in numerical order. However, PrettyScribe doesn't place them in the same order presented

Example of bug:

EoD

Example of working in BattleScribe:

EoD_bs

Example of the first two in the AoS App:

EoD_App

Troubleshooting tried:

  • Changing weapons on Black Coach (between Reaper Scythe and Soulreach Grasp)
  • Adding other models to the roster
  • Naming the model in BattleScribe

Attached:
Coach only rosz in zip file

BlackCoachOnly.zip

Age of Sigmar - OBR not showing allegiance abilities.

I'm not sure if this is an issue with the battlescribe file/output for the new Ossiarch Bonereapers, or a prettyscribe issue but basically when I use an OBR roster file, it only displays the sub-faction allegiance abilities, not the general faction-wide allegiance abilities.

40k: Adding units to a 2nd detachment causes most of the force rules and selection rules to not display

This relates to the 40k 9th edition data set. If a 2nd detachment is added, and a unit added to that detachment, in PrettyScribe most of the force rules and selection rules do not display. Some do, it seems a bit arbitrary. Adding a 2nd empty detachment doesn't seem to cause the problem - it seems to occur as soon as a unit is added to the 2nd detachment. The detachment type doesn't seem to effect the issue.

DarkAngelsTest.zip

Love it

I don't have any issue to report. I just wanted to mention how badass this is.

Possibility to change the order of the data sheets

I would like to request the feature to be able to change the order of the data sheets, something like "move up/down" buttons for each data card.

Now in 10th edition where leaders join units it is useful to have those data sheets next to each other so you can look at how they affect each other and go through them one by one after each other when shooting/fighting.

I use PrettyScribe to print to PDF and then view the PDF on my iPad as I play, and right now I have to scroll up and down a lot when going through each unit with multiple data sheets.

Age of Sigmar - Graphics not printing

When printing out AoS lists, the text from the warscroll medalion (move, wounds, save, bravery) will print, but the graphic with the labels is missing, so you are unable to see the labels for the numbers. Screenshot attached from print preview dialog box.
image

Minor changes on fork

Hello,

As you might have noticed, I forked your work.
It is pretty amazing, but it was chunky in some places and had issues in some other places.

I have pretty much all changes in a single commit, so you might need to dig through if you want to merge some changes back.

My Changes:

  • The models in the unit list is sometimes pretty useless. My list contains models with the same name but different loadout. The original looks like this:

Acolyte Leader, 5 Acolyte Hybrid, Acolyte Hybrid, Acolyte Hybrid, Acolyte Hybrid, Acolyte Hybrid

My change is to include every model with its updates and weapons (each on a new line):

5x Acolyte Hybrid (Blasting Charge, Cultist Knife, Hand Flamer, Rending Claw(s))
3x Acolyte Hybrid (Blasting Charge, Hand Flamer, Heavy Rock Saw)
Acolyte Hybrid (Blasting Charge, Hand Flamer, Heavy Rock Cutter)
Acolyte Leader (Blasting Charge, Cultist Knife, Hand Flamer, Rending Claw(s))

  • I repeat the force title before the unit canvas (and print the correct faction/sub-faction as well).

Tyranids - Genestealer Cults (The Pauper Princes)

  • The general canvas is broader so it fits the width of a DIN A4 page. This works right now, but if I try to resize or change paper settings I get blurred text on canvas. No clue how to fix that.

  • I adopted the table column sizes to make full use of the extra space for abilities and details.

  • I adapted the Psykers section and turned it into a single line with the same information

  • I removed the Rules section. The Rules are now mentioned in "abilities" and are printed once at the end of the list. sub-faction specific rules are printed separately.

Tyranids - Genestealer Cults

Cult Ambush
During deployment, ...
Unquestioning Loyalty
Each time ...

The Pauper Princes

Devoted Zealots
You can re-roll ...

  • The Models shows the same information as in the initial list, i.e. Models with gear and Weapons.

Give it a try and see if you can use some of my changes.

kind regards, Mario

Missing and duplicate sections within a unit block from .ROSZ import

Current
When importing a .ROSZ file previously I would see section about the 'UNIT' with the characteristics like Movement, Toughness, etc but in some cases this has disappered and instead skips straight to the weapon profiles. In some cases the 'UNIT' section is there but only includes one of the profiles or duplicates.

I have also noticed various duplicate weapon profiles in both the 'RANGED' and 'MELEE' sections.

image
image
image

Expected
Each unit block should contain one copy of all applicable 'UNIT', 'RANGED WEAPON, 'MELEE WEAPON' profile.


I was wondering if Battlescribe (v. 2.03.21) or the Battlescribe Data (v. 10.1.4)has changed how it's now recording model configurations. So when I equip a special weapon, that "model" is being treat as it's own entity (i.e. has it's own 'UNIT' profile, any basic loadout weapons are duplicated etc). Not sure why that would cause some 'UNIT' profiles to disapear though unless there is a limit. I've attached my .ROSZ (changed the file type to .txt to allow it to be uploaded) and a PDF from PrettyScribe as well as how Battlescribe exports my list.

01 LoV Leviathan v0102.txt

PrettyScribe 01 _ LoV _ Leviathan _ v0102.pdf

01 LoV Leviathan v0102.html.pdf

Black Coach's Damage Table doesn't display correctly

Issue: When using the Black Coach from Age of Sigmar's "Death - Nighthaunt" army the Damage Table doesn't show up correctly

Example of current bug:
BlackCoachTable

Expected outcome:
Have a table that shows the chart of distance and attack count by wounds taken

Example from BattleScribe:

BlackCoachTable_bs

Example from AoS Mobile App:

BlackCoachTable_App

rosz file containing only Black Coach (in a zip file):

BlackCoachOnly.zip

Things I've tried:

  • Switching optional weapon between Soulreach Grasp and Reaper Scythe
  • Naming the unit
  • Adding other units to the same roster

Possibly related, can open a new bug if you'd like:

The table for "Evocation of Death" doesn't appear in numerical order:

Example from PrettyScribe:

EoD

As displayed in BattleScribe:

EoD_bs

Ability to hide elements

Hello,

I've implemented the function to hide (some) elements.
Use-Cases:

  • The datasheet describes an ability which depends on an (not chosen) upgrade
  • Abilities per Phase .. same reason as above
  • Weapon Upgrade -> original weapon gets replaced and should not be printed

The new option "Hide Elements from Printing" highlights hide-able elements on hover and strikes them through on click. Those elements are hidden when printing.

Customizing output

Is it possible to hide the Prettyscribe title and "Select Roster file" message from the output when printing? The workaround is removing it by inspecting the page in Chrome.

Also some of the formatting doesn't look quite right in the end section when there are multiple lines or a list. For example listing the Canticles of the Omnissiah in an Adeptus Mechanicus list. It just puts them all into one long paragraph rather than separate lines.

WH40k 9th rosters weapons and subfaction rules don't show

I noticed a couple problems when using PrettyScribe on a small Necrons force with WH40k 9th edition setup:
Necron June 2021 2.zip

  • weapons don't always show up. poking around: the Royal Warden's information is listed after its information (which is nested inside a ), so the method CreateUnit fails nukes the weapon info when it sees the unit info:

    model = new Model();
    . All units have this problem.

  • custom dynasties info don't show up either. the subfaction rules are listed as "Dynastic Code" rather than "Abilities", so the rules aren't extracted

Possible Dark Mode or Colour Customization Options

Would it be possible to have an option to set the output to be produced on a black/dark background with light text? I don't know how simple that is to do with the unit data images, but it would make the HTML text a bit easier on the eyes for using PrettyScribe on a portable device instead of printing.

Wheel too big in AoS rosters?

First of all - many thanks for a great tool that I use and love :)

I'm trying to print the prettyfied roster on Google Chrome (newest stable). This is how it looks like on an A4 page:
image

I feel like there's a lot of wasted space, the wheel could be smaller.

KT21 EP bug

If an operative has two pieces of equipment, for example, one that costs 2 EP and another that costs 3 EP, the header shows "23" instead of "5"

I fixed it and submitted a PR: #43

Thanks for the awesome app!

AoS - Soulblight Gravelords - Invigorating Aura missing

The Soulblight Gravelords spell Invigorating Aura (which they all get) does not print along with the rest of the Allegiance Abilities as it does in the standard Battlescribe output, nor is it included in the separate unit entries. I've attached an HTML file showing the output from Battlescribe if that helps.

Great job on the list output, though!

Soulblight Army List.zip

Certain weapons are overlaying range stat

Hey, it seems some weapons with really long names are leaking into the ranged stat slightly and overlaying over the ranged stat, I included the one I found when doing a list today.

weapons.zip
Screenshot 2021-07-30 140920

This is a fantastic tool btw, huge appreciation for what you have done here.

Kill Team (2021)

Create renderer and roster for KT21.
I will give it a shot this week. I am sure I will need help with graphics. In the meantime I will use placeholders from old KT.

Suggestion

This app is great! It would be awesome to be able to choose a minimalist output with just the units and loadouts so your list can be shared on Discord and Reddit.

New GSC Codex issues

  • Unit profiles are missing the point costs for their upgrades. I guess the switch and reimplementation of the renderer introduced the issue.
  • Some phases are missing because the wording is different: "coming from Reinforcement" or "before the first turn".
  • Some abilities are duplicated: e.g. "open-topped"

I'll try to fix this.

Edit margins

Is it possible to add a feature to edit the margins? It would be very handy for creating datacards. As the sheets come now, they are very wide, it would be nice if one could make them narrower.

Kill Team display

Make the Kill Team roster display more like the actual Kill Team data cards.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.