ruthmy / leaderboardproject Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
β
Good commit history.
β
ES6 syntax.
β
Clear and readable variable/function naming convention.
β
Gitflow followed.
By @ITurres:
You have done an outstanding job @Ruthmy!π―
The only two suggestions I can make so far are:
Kindly consider a more modular
approach, separating functions, events, and API consumers from each other. This will make your code more readable and maintainable. You can see more about it here JS Modules.
Consider good practice for the commit
s to match the changes made as well as committing for a small chunk of changes. e.g. most of the commits on this branch are descriptive, which is a good thing! :D, but for example commit #5f9627f
holds 2 diff file changes, it would be a good idea to have separated those 2 different file changes into 2 diffs commit
messages, for it to be easier to debug in the future.
By @Diegogagan2587:
Great Job So far π, I did notices that in the file src/modules/scores.js
at line 27 you are appending a <p>
element to show the user when they are trying to submit without fill the inputs, you could add a class for that element so it will be displayed at the center!.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.