ruthmy / leaderboardproject Goto Github PK

Hi @Ruthmy

Your project looks very good with that personal design touch, great job!💪

⭐Highlights⭐

✅ Good commit history.
✅ ES6 syntax.
✅ Clear and readable variable/function naming convention.
✅ Gitflow followed.

Keep up the good work 🏆

---

Nevertheless, We can suggest the following

Team Suggested Changes ♻️

By @ITurres:

You have done an outstanding job @Ruthmy!🎯

The only two suggestions I can make so far are:

• Kindly consider a more modular approach, separating functions, events, and API consumers from each other. This will make your code more readable and maintainable. You can see more about it here JS Modules.

• Consider good practice for the commits to match the changes made as well as committing for a small chunk of changes. e.g. most of the commits on this branch are descriptive, which is a good thing! :D, but for example commit #5f9627f holds 2 diff file changes, it would be a good idea to have separated those 2 different file changes into 2 diffs commit messages, for it to be easier to debug in the future.

---

By @Diegogagan2587:

Great Job So far 👍, I did notices that in the file src/modules/scores.js at line 27 you are appending a <p> element to show the user when they are trying to submit without fill the inputs, you could add a class for that element so it will be displayed at the center!.

---