Adding http method as dimension about akka-http-metrics HOT 3 CLOSED

Hi @wake42.
That's a great suggestion. Just in time for v1.0.0. I'm adding this to the milestone

from akka-http-metrics.

Hi,
Thanks for this, it works really well, but we have a problem. OPTIONS is also a method, but that one is not handled with path (pathLabeled) in Akka so right now all OPTIONS register with full path including any id:s (OPTIONS /user/1 becomes a different metric from /user/2). I tried to add a path for OPTIONS but it seems that our cors handling is responding before we get to the routes.
Do you have any good idea of how to handle this.
We would be fine with dropping all OPTIONS calls from the metrics.

from akka-http-metrics.

Thanks for coming back on this issue. I suppose you are using akka-http-cors. The issue comes form this line.

Basically, when developing akka-http-metrics I made the wrong assumption that success responses are created when path is fully matched. This is not the case.

There are 2 possible solutions:

• Have a custom RequestContext that can tell on complete how much of the path was matched
• Have the path labelled as opt-in

In both cases this is not related to the http method. I'm closing this issue and will reference it in a new dedicated one.

from akka-http-metrics.