Giter Club home page Giter Club logo

Comments (7)

RustedBones avatar RustedBones commented on May 20, 2024 1

This is related to #227.
I faced some issues working on the next major. I'll probably try to backport some of the improvements to create a new release supporting custom dimensions

from akka-http-metrics.

RustedBones avatar RustedBones commented on May 20, 2024 1

Thank you so much @aleksandr-vin for testing the release and for the valuable feedback!
I've updated the snapshot. You can give another shot and if everything is OK I'll publish v1.7.0

from akka-http-metrics.

aleksandr-vin avatar aleksandr-vin commented on May 20, 2024 1

You have only one typo in CHANGELOG.md: see form -> from:

- Change form sequence to varagrs API in settings

from akka-http-metrics.

RustedBones avatar RustedBones commented on May 20, 2024

I just created a 1.7.0-SNAPSHPOT release. Can you give it a try and let me know if it fits your needs?

from akka-http-metrics.

aleksandr-vin avatar aleksandr-vin commented on May 20, 2024

Thanks for implementation, @RustedBones!!

Here are my findings so far:

  1. Error in the README.md: #254
  2. Swapped path and status labels in Prometheus: #255

from akka-http-metrics.

aleksandr-vin avatar aleksandr-vin commented on May 20, 2024

Also some thing that can make it more expressive. As the withCustomDimensions & withServerDimensions are supposed to be called with the static lists of dimensions, the code could be concise if varargs syntax is used.

from akka-http-metrics.

aleksandr-vin avatar aleksandr-vin commented on May 20, 2024

I've checked, it's awesome! Thanks for quick fix!

from akka-http-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.