rustcrypto / ring-compat Goto Github PK

Would it make sense to unify all of the ring wrappers into a single crate, with the algorithm-specific functionality gated behind cargo features?

I think that would make it easier to coordinate upgrades, especially for downstream users.

Also sidebar: I have some wrappers for ECDSA and Ed25519 signing/verification I'd like to upstream: https://github.com/iqlusioninc/signatory/tree/develop/signatory-ring/src

Which was added in #80 .

It can be done similarly to RustCrypto/media#1 by using SVG with CSS rules dependent on @media (prefers-color-scheme: light/dark) { .. } selector.

The current latest version on crates.io doesn't depend on aead v0.5.

How are we going to manage the teams for this? Should the AEAD team own ring-aead and the Digest team own ring-digest, or should we make a new team just for ring-wrappers?

I'm following the Ed25519 documentation for signing and verifying and I'm stuck
trying to generate a valid key that can be loaded by ring-compat.

Is there documentation for how to invoke openssl or ssh-keygen to generate keys, along with relevant code samples for loading keys?

@tarcieri suggested that ring-compat might want to support key generation. I'd be equally happy with that resolution.

Context

I want to create a ring_compat::signature::ed25519::SigningKey from a Ed25519 PKCS#8 v1 private key. The existing functions for SigningKey is for PKCS8#8 v2 private keys (from_pkcs8).

The ring crate supports PKCS#8 v1 keys by supplying the from_pkcs8_maybe_unchecked function.
So you can create a ring::signature::Ed25519KeyPair using from_pkcs8_maybe_unchecked function but you cannot create the ring_compat::signature::ed25519::SigningKey once you have the Ed25519KeyPair because the field of the SigningKey struct is private.

Possible Solutions

1. add from_pkcs8_maybe_unchecked to implementations of SigningKey for ring-compat
2. create a constructor for SigningKey taking in Ed25519KeyPair

Is it possible to push another release? Thank you