Giter Club home page Giter Club logo

netlink-packet-utils's People

Contributors

a1ien avatar cathay4t avatar dzamlo avatar gabrik avatar hermantolim avatar johntitor avatar leo1003 avatar little-dude avatar svart avatar wllenyj avatar

Watchers

 avatar  avatar

netlink-packet-utils's Issues

Test fail on s390x

---- nla::tests::network_byteorder stdout ----
thread 'nla::tests::network_byteorder' panicked at 'range end index 2048 out of range for slice of length 8', src/nla.rs:168:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
failures:
nla::tests::network_byteorder
test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
error: test failed, to rerun pass --lib

`DecodeError` with `sfq` qdisc

The library panics when trying to parse an sfq qdisc.

Steps to reproduce

  1. Add a dummy interface:
sudo ip link add dummy1 type dummy
sudo tc qdisc add dev dummy1 parent root handle 1:0 sfq
  1. Try to read the qdiscs:
#[test]
fn test_qdisc() {
    use netlink_packet_core::{
        NetlinkHeader, NetlinkMessage, NetlinkPayload, NLM_F_DUMP, NLM_F_REQUEST,
    };
    use netlink_sys::{protocols::NETLINK_ROUTE, Socket, SocketAddr};

    use crate::RtnlMessage;

    let socket = Socket::new(NETLINK_ROUTE).unwrap();
    socket.connect(&SocketAddr::new(0, 0)).unwrap();

    let mut nl_hdr = NetlinkHeader::default();
    nl_hdr.flags = NLM_F_REQUEST | NLM_F_DUMP;

    let mut packet = NetlinkMessage::new(
        nl_hdr,
        NetlinkPayload::from(RtnlMessage::GetQueueDiscipline(TcMessage::default())),
    );
    packet.finalize();

    let mut buf = vec![0; packet.header.length as usize];
    packet.serialize(&mut buf[..]);
    socket.send(&buf[..], 0).unwrap();

    let mut receive_buffer = vec![0; 4096];
    let mut offset = 0;

    let mut tc_messages = Vec::new();
    while let Ok(size) = socket.recv(&mut &mut receive_buffer[..], 0) {
        let mut i: u8 = 0;
        loop {
            i += 1;
            if i == 6 {
                println!("sfq");
            }
            let bytes = &receive_buffer[offset..];
            // !!! PANICS here !!!
            let rx_packet = <NetlinkMessage<RtnlMessage>>::deserialize(bytes).unwrap();

            let payload = rx_packet.payload;
            match payload {
                NetlinkPayload::InnerMessage(RtnlMessage::NewQueueDiscipline(message)) => {
                    tc_messages.push(message.clone())
                }
                NetlinkPayload::Error(error) => {
                    panic!("Received Netlink Error: {:?}", error);
                }
                NetlinkPayload::Done(_) => break,
                _ => {}
            }

            offset += rx_packet.header.length as usize;
            if offset == size || rx_packet.header.length == 0 {
                offset = 0;
                break;
            }
        }
    }
}

More information

The error is because of this logic

} else if len < self.length() as usize {

DecodeError { inner: invalid NLA buffer

Caused by:
    Decode error occurred: buffer has length: 72, but the NLA is 1514 bytes }

Use `thiserror` instead of `anyhow`?

anyhow::Error is an opaque type and dynamically dispatched. It can be useful to present errors as an enum in order for downstream users to see what error has occurred.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.